Re: [PATCH v3 bpf-next 06/11] bpf: implement accurate raw_tp context access via BTF

2019-10-16 Thread Alexei Starovoitov
On 10/16/19 3:08 PM, Daniel Borkmann wrote: > On 10/16/19 11:28 PM, Alexei Starovoitov wrote: >> On Wed, Oct 16, 2019 at 2:22 PM Daniel Borkmann >> wrote: >>> On 10/16/19 5:25 AM, Alexei Starovoitov wrote: libbpf analyzes bpf C program, searches in-kernel BTF for given type name a

Re: [PATCH v3 bpf-next 06/11] bpf: implement accurate raw_tp context access via BTF

2019-10-16 Thread Daniel Borkmann
On 10/16/19 11:28 PM, Alexei Starovoitov wrote: On Wed, Oct 16, 2019 at 2:22 PM Daniel Borkmann wrote: On 10/16/19 5:25 AM, Alexei Starovoitov wrote: libbpf analyzes bpf C program, searches in-kernel BTF for given type name and stores it into expected_attach_type. The kernel verifier expects t

Re: [PATCH v3 bpf-next 06/11] bpf: implement accurate raw_tp context access via BTF

2019-10-16 Thread Alexei Starovoitov
On Wed, Oct 16, 2019 at 2:22 PM Daniel Borkmann wrote: > > On 10/16/19 5:25 AM, Alexei Starovoitov wrote: > > libbpf analyzes bpf C program, searches in-kernel BTF for given type name > > and stores it into expected_attach_type. > > The kernel verifier expects this btf_id to point to something lik

Re: [PATCH v3 bpf-next 06/11] bpf: implement accurate raw_tp context access via BTF

2019-10-16 Thread Daniel Borkmann
On 10/16/19 5:25 AM, Alexei Starovoitov wrote: libbpf analyzes bpf C program, searches in-kernel BTF for given type name and stores it into expected_attach_type. The kernel verifier expects this btf_id to point to something like: typedef void (*btf_trace_kfree_skb)(void *, struct sk_buff *skb, vo

Re: [PATCH v3 bpf-next 06/11] bpf: implement accurate raw_tp context access via BTF

2019-10-16 Thread Andrii Nakryiko
On Wed, Oct 16, 2019 at 4:16 AM Alexei Starovoitov wrote: > > libbpf analyzes bpf C program, searches in-kernel BTF for given type name > and stores it into expected_attach_type. > The kernel verifier expects this btf_id to point to something like: > typedef void (*btf_trace_kfree_skb)(void *, str

[PATCH v3 bpf-next 06/11] bpf: implement accurate raw_tp context access via BTF

2019-10-15 Thread Alexei Starovoitov
libbpf analyzes bpf C program, searches in-kernel BTF for given type name and stores it into expected_attach_type. The kernel verifier expects this btf_id to point to something like: typedef void (*btf_trace_kfree_skb)(void *, struct sk_buff *skb, void *loc); which represents signature of raw_trace