Re: [PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-27 Thread Kurt Kanzenbach
Hi Andrew, On Tue Aug 25 2020, Kurt Kanzenbach wrote: > On Tue Aug 25 2020, Andrew Lunn wrote: >> I agree with the check here. The question is about the compatible >> string. Should there be a more specific compatible string as well as >> the generic one? >> >> There have been a few discussions ab

Re: [PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-25 Thread Kurt Kanzenbach
On Tue Aug 25 2020, Andrew Lunn wrote: > I agree with the check here. The question is about the compatible > string. Should there be a more specific compatible string as well as > the generic one? > > There have been a few discussions about how the Marvell DSA driver > does its compatible string. T

Re: [PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-25 Thread Andrew Lunn
> >> +static int hellcreek_detect(struct hellcreek *hellcreek) > >> +{ > >> + u16 id, rel_low, rel_high, date_low, date_high, tgd_ver; > >> + u8 tgd_maj, tgd_min; > >> + u32 rel, date; > >> + > >> + id= hellcreek_read(hellcreek, HR_MODID_C); > >> + rel_low = hellcreek_read(hellcreek,

Re: [PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-25 Thread Kurt Kanzenbach
On Tue Aug 25 2020, Andrew Lunn wrote: [snip] >> >> source "drivers/net/dsa/sja1105/Kconfig" >> >> +source "drivers/net/dsa/hirschmann/Kconfig" >> + >> config NET_DSA_QCA8K >> tristate "Qualcomm Atheros QCA8K Ethernet switch family support" >> depends on NET_DSA > > Hi Kurt > > The

Re: [PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-24 Thread Andrew Lunn
On Thu, Aug 20, 2020 at 10:11:12AM +0200, Kurt Kanzenbach wrote: > Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are > implementing features needed for Time Sensitive Networking (TSN) such as > support > for the Time Precision Protocol and various shapers like the Time A

[PATCH v3 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-08-20 Thread Kurt Kanzenbach
Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are implementing features needed for Time Sensitive Networking (TSN) such as support for the Time Precision Protocol and various shapers like the Time Aware Shaper. This driver includes basic support for networking: * VLAN