Re: [PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support

2020-09-20 Thread Robert Marko
On Sun, Sep 20, 2020 at 2:19 AM Andrew Lunn wrote: > > > + > > +/* 0 = Clause 22, 1 = Clause 45 */ > > +#define MDIO_MODE_BITBIT(8) > > How about calling this MDIO_MODE_C45 Good idea, will rename it. > > > + /* Enter Clause 45 mode */ > > +

Re: [PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support

2020-09-19 Thread Andrew Lunn
> + > +/* 0 = Clause 22, 1 = Clause 45 */ > +#define MDIO_MODE_BITBIT(8) How about calling this MDIO_MODE_C45 > + /* Enter Clause 45 mode */ > + data = readl(priv->membase + MDIO_MODE_REG); > + > + data |= MDIO_MODE_BIT; > + > +

[PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support

2020-09-18 Thread Robert Marko
While up-streaming the IPQ4019 driver it was thought that the controller had no Clause 45 support, but it actually does and its activated by writing a bit to the mode register. So lets add it as newer SoC-s use the same controller and Clause 45 compliant PHY-s. Signed-off-by: Robert Marko Cc: