Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-08 Thread 严海双
> On 8 Jun 2017, at 9:59 PM, David Miller wrote: > > From: 严海双 > Date: Thu, 8 Jun 2017 15:33:58 +0800 > >>> On 8 Jun 2017, at 1:00 PM, Alexei Starovoitov >>> wrote: >>> >>> On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote: > On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-08 Thread David Miller
From: 严海双 Date: Thu, 8 Jun 2017 15:33:58 +0800 >> On 8 Jun 2017, at 1:00 PM, Alexei Starovoitov >> wrote: >> >> On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote: >>> On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov wrote: On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haish

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-08 Thread David Miller
From: Alexei Starovoitov Date: Wed, 7 Jun 2017 22:00:43 -0700 > On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote: >> >> > On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov >> > wrote: >> > >> > On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: >> >> When __ip6_tnl_rcv fails, the

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-08 Thread 严海双
> On 8 Jun 2017, at 1:00 PM, Alexei Starovoitov > wrote: > > On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote: >> >>> On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov >>> wrote: >>> >>> On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: When __ip6_tnl_rcv fails, the tun_dst

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Alexei Starovoitov
On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote: > > > On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov > > wrote: > > > > On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: > >> When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call > >> dst_release to free it in error cod

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Eric Dumazet
On Wed, Jun 7, 2017 at 9:38 PM, Alexei Starovoitov wrote: > On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: >> When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call >> dst_release to free it in error code path. >> >> CC: Alexei Starovoitov >> Fixes: 8d79266bc48c ("ip6_tunne

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Alexei Starovoitov
On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: > When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call > dst_release to free it in error code path. > > CC: Alexei Starovoitov > Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") > Signed-off-by: Haishua

[PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Haishuang Yan
When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call dst_release to free it in error code path. CC: Alexei Starovoitov Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") Signed-off-by: Haishuang Yan --- Changes in v2: - Add the the missing Fixes information Chang