Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-07 Thread Vivien Didelot
Hi Guenter, Andrew, - On Jul 7, 2015, at 12:07 PM, Andrew Lunn and...@lunn.ch wrote: >> Indeed, I intentionally kept it as is, since the 88E6352 datasheet is not >> really clear about this. I see that the register 0x09 (called >> GLOBAL_VTU_DATA_8_11 in mv88e6xxx.h) only contains VID priority

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-07 Thread Andrew Lunn
> Indeed, I intentionally kept it as is, since the 88E6352 datasheet is not > really clear about this. I see that the register 0x09 (called > GLOBAL_VTU_DATA_8_11 in mv88e6xxx.h) only contains VID priority related bits > in > 15:12, in my case. As bits 11:0 are reserved, I suspect that the offsets

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-07 Thread Guenter Roeck
On 07/07/2015 08:52 AM, Vivien Didelot wrote: Hi Andrew, On Jul 6, 2015, at 10:08 PM, Andrew Lunn and...@lunn.ch wrote: +static int _mv88e6xxx_vtu_getnext(struct dsa_switch *ds, u16 vid, + struct mv88e6xxx_vtu_entry *entry) +{ + int ret, i; + + ret =

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-07 Thread Vivien Didelot
Hi Andrew, On Jul 6, 2015, at 10:08 PM, Andrew Lunn and...@lunn.ch wrote: >> +static int _mv88e6xxx_vtu_getnext(struct dsa_switch *ds, u16 vid, >> + struct mv88e6xxx_vtu_entry *entry) >> +{ >> +int ret, i; >> + >> +ret = _mv88e6xxx_vtu_wait(ds); >> +if (re

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-06 Thread Andrew Lunn
> +static int _mv88e6xxx_vtu_getnext(struct dsa_switch *ds, u16 vid, > + struct mv88e6xxx_vtu_entry *entry) > +{ > + int ret, i; > + > + ret = _mv88e6xxx_vtu_wait(ds); > + if (ret < 0) > + return ret; > + > + ret = _mv88e6xxx_reg_write(ds, R

[PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-07-05 Thread Vivien Didelot
Implement the Get Next and Load Purge operations for the VLAN Table Unit, and a "vtu" debugfs file to read and write the hardware VLANs. A populated VTU look like this: # cat /sys/kernel/debug/dsa0/vtu VID FID SID 0 1 2 3 4 5 6 550 5620 x x x u x t x 1000 10