Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-10 Thread Neil Horman
On Wed, Jun 10, 2015 at 10:31:42AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Jun 09, 2015 at 04:32:59PM -0300, Marcelo Ricardo Leitner wrote: > > On Tue, Jun 09, 2015 at 07:36:38AM -0400, Neil Horman wrote: > > > On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: > > > > On

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-10 Thread Marcelo Ricardo Leitner
On Tue, Jun 09, 2015 at 04:32:59PM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Jun 09, 2015 at 07:36:38AM -0400, Neil Horman wrote: > > On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: > > > On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: > > > > On Mon, Jun 08, 2015 a

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-09 Thread Marcelo Ricardo Leitner
On Tue, Jun 09, 2015 at 07:36:38AM -0400, Neil Horman wrote: > On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: > > On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: > > > On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: > > > > On Mon, Jun 8, 2015, at 1

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-09 Thread Neil Horman
On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: > On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: > > On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: > > > On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: > > > > Hi Marcelo, > > > > > > >

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Hannes Frederic Sowa
On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: > On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: > > On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: > > > Hi Marcelo, > > > > > > a few hints on rcuification, sorry I reviewed the code so late: > > > > > > On

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Neil Horman
On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: > On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: > > Hi Marcelo, > > > > a few hints on rcuification, sorry I reviewed the code so late: > > > > On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: > > > From:

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Hannes Frederic Sowa
On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: > Hi Marcelo, > > a few hints on rcuification, sorry I reviewed the code so late: > > On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: > > From: Marcelo Ricardo Leitner > > > > That's needed for the next patch, so we break the

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Hannes Frederic Sowa
Hi Marcelo, a few hints on rcuification, sorry I reviewed the code so late: On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: > From: Marcelo Ricardo Leitner > > That's needed for the next patch, so we break the lock inversion between > netns_sctp->addr_wq_lock and socket lock on > sctp

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Neil Horman
On Fri, Jun 05, 2015 at 02:08:05PM -0300, mleit...@redhat.com wrote: > From: Marcelo Ricardo Leitner > > That's needed for the next patch, so we break the lock inversion between > netns_sctp->addr_wq_lock and socket lock on > sctp_addr_wq_timeout_handler(). With this, we can traverse addr_waitq >

[PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-05 Thread mleitner
From: Marcelo Ricardo Leitner That's needed for the next patch, so we break the lock inversion between netns_sctp->addr_wq_lock and socket lock on sctp_addr_wq_timeout_handler(). With this, we can traverse addr_waitq without taking addr_wq_lock, taking it just for the write operations. Signed-of