Re: [PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread David Miller
It is never, ever, appropriate to use the same exact Subject: line text for two different changes. Someone looking at "git shortlog" has no way to know what is different between the two changes. You must put care and time into constructing Subject: lines because this text is critical for data mi

[PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841 Reported-by: Pan Bian Sig