Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-04 Thread Feng Gao
The link is https://patchwork.ozlabs.org/patch/655695/ Best Regards Feng On Thu, Aug 4, 2016 at 3:37 PM, Feng Gao wrote: > Hi Tom & Philp, > > The v4 patch is sent already. > Could you help review again please? > > Tom, > I follow your modification. > > Philp, > I define one new struct gre_full_

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-04 Thread Feng Gao
Hi Tom & Philp, The v4 patch is sent already. Could you help review again please? Tom, I follow your modification. Philp, I define one new struct gre_full_hdr which contains the completed gre header, for example, csum, key, and so on. And these members are not defined in gre_base_hdr. It is only

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-03 Thread Philp Prindeville
Inline On 08/03/2016 05:58 PM, Feng Gao wrote: inline comment. There are two comments that I am not clear. Best Regards Feng On Thu, Aug 4, 2016 at 4:43 AM, Philip Prindeville wrote: Inline… On Aug 3, 2016, at 8:52 AM, f...@48lvckh6395k16k5.yundunddos.com wrote: From: Gao Feng The PPTP

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-03 Thread Feng Gao
inline comment. There are two comments that I am not clear. Best Regards Feng On Thu, Aug 4, 2016 at 4:43 AM, Philip Prindeville wrote: > Inline… > >> On Aug 3, 2016, at 8:52 AM, f...@48lvckh6395k16k5.yundunddos.com wrote: >> >> From: Gao Feng >> >> The PPTP is encapsulated by GRE header with t

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-03 Thread Feng Gao
Hi Tom, inline comments On Thu, Aug 4, 2016 at 12:15 AM, Tom Herbert wrote: > On Wed, Aug 3, 2016 at 7:52 AM, wrote: >> From: Gao Feng >> >> The PPTP is encapsulated by GRE header with that GRE_VERSION bits >> must contain one. But current GRE RPS needs the GRE_VERSION must be >> zero. So RPS

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-03 Thread Philip Prindeville
Inline… > On Aug 3, 2016, at 8:52 AM, f...@48lvckh6395k16k5.yundunddos.com wrote: > > From: Gao Feng > > The PPTP is encapsulated by GRE header with that GRE_VERSION bits > must contain one. But current GRE RPS needs the GRE_VERSION must be > zero. So RPS does not work for PPTP traffic. > > In

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-03 Thread Tom Herbert
On Wed, Aug 3, 2016 at 7:52 AM, wrote: > From: Gao Feng > > The PPTP is encapsulated by GRE header with that GRE_VERSION bits > must contain one. But current GRE RPS needs the GRE_VERSION must be > zero. So RPS does not work for PPTP traffic. > > In my test environment, there are four MIPS cores

[PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-03 Thread fgao
From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test environment, there are four MIPS cores, and all traffic are passed through by PPTP. As a re