Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-25 Thread Florian Fainelli
On 8/25/2020 4:21 AM, Kurt Kanzenbach wrote: On Mon Aug 24 2020, David Miller wrote: Agreed, Kurt can you repost this series without the TAPRIO support for now since it's controversial and needs more discussion and changes? OK. It seems like the TAPRIO implementation has to be discussed mor

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-25 Thread Kurt Kanzenbach
On Mon Aug 24 2020, David Miller wrote: > Agreed, Kurt can you repost this series without the TAPRIO support for > now since it's controversial and needs more discussion and changes? OK. It seems like the TAPRIO implementation has to be discussed more and it might be good to do that separately. I

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread Vladimir Oltean
On Mon, Aug 24, 2020 at 03:35:18PM -0700, David Miller wrote: > From: Vladimir Oltean > Date: Tue, 25 Aug 2020 01:02:03 +0300 > > > Just my comment on patch 5/8 about netdev->tc_to_txq. There are 2 > > distinct things about that: > > - accessing struct net_device directly hurts the DSA model a li

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread David Miller
From: Vladimir Oltean Date: Tue, 25 Aug 2020 01:02:03 +0300 > Just my comment on patch 5/8 about netdev->tc_to_txq. There are 2 > distinct things about that: > - accessing struct net_device directly hurts the DSA model a little bit. > - I think there's some confusion regarding the use of netdev->

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread Vladimir Oltean
On Mon, Aug 24, 2020 at 02:31:10PM -0700, Jakub Kicinski wrote: > On Thu, 20 Aug 2020 10:11:10 +0200 Kurt Kanzenbach wrote: > > this series adds a DSA driver for the Hirschmann Hellcreek TSN switch > > IP. Characteristics of that IP: > > > > * Full duplex Ethernet interface at 100/1000 Mbps on th

Re: [PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-24 Thread Jakub Kicinski
On Thu, 20 Aug 2020 10:11:10 +0200 Kurt Kanzenbach wrote: > this series adds a DSA driver for the Hirschmann Hellcreek TSN switch > IP. Characteristics of that IP: > > * Full duplex Ethernet interface at 100/1000 Mbps on three ports > * IEEE 802.1Q-compliant Ethernet Switch > * IEEE 802.1Qbv Ti

[PATCH v3 0/8] Hirschmann Hellcreek DSA driver

2020-08-20 Thread Kurt Kanzenbach
Hi, this series adds a DSA driver for the Hirschmann Hellcreek TSN switch IP. Characteristics of that IP: * Full duplex Ethernet interface at 100/1000 Mbps on three ports * IEEE 802.1Q-compliant Ethernet Switch * IEEE 802.1Qbv Time-Aware scheduling support * IEEE 1588 and IEEE 802.1AS support