Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-11-08 Thread f6bvp
Hi all, I just want to report that I applied the NetRom patch to most recent kernel. NetRom does not seem to be affected and connexion is doing well between my FPAC node f6bvp and f3kt. 73 de Bernard f6bvp Sent from my iPhone > Le 29 oct. 2017 à 05:15, David Ranch a écrit : > > > Hello Davi

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-11-01 Thread Gustavo A. R. Silva
Quoting David Miller : From: "Gustavo A. R. Silva" Date: Fri, 27 Oct 2017 00:50:57 -0500 The aim of this patchset is firstly to refactor code in nr_route.c in order to make it easier to read and maintain and, secondly, to mark some expected switch fall-throughs in preparation to enabling

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-11-01 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 27 Oct 2017 00:50:57 -0500 > The aim of this patchset is firstly to refactor code in nr_route.c in order > to make it > easier to read and maintain and, secondly, to mark some expected switch > fall-throughs > in preparation to enabling -Wimplicit-fallthro

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-28 Thread David Ranch
Hello David, Thanks for the reply. I completely admit that there aren't many changes going into this section of code. Unfortunately, we've had some nasty breaks that took quite a long while to get fixed. Can you point me in the direction of this kbuild test robot (URLs, etc) so I can bett

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-28 Thread David Miller
From: David Ranch Date: Sat, 28 Oct 2017 10:53:24 -0700 > Does anyone else have thoughts on this topic? I think you are making a mountain out of a mole hill. If you care so much about this, set things up so that entities such as the kbuild test robot run whatever tests you think are necessary.

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-28 Thread David Ranch
Hello Gustavo, Thanks for the reply. I do appreciate the work but we've had other people contribute to keep things up to date but previous minor patches broke parts of the AX.25 stack in strange ways. The fixes weren't hard to repair or backout but due to the timing, various Linux distros b

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-27 Thread Gustavo A. R. Silva
Hi David, Quoting David Ranch : Hello Gustavo, I appreciate you working on keeping up the kernel and maintaining some of the older feature areas like AX.25, Netrom, etc. Other than auditing your code changes, can you tell me what you're changing? I've been attempting to find who / where

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-27 Thread David Ranch
Hello Gustavo, I appreciate you working on keeping up the kernel and maintaining some of the older feature areas like AX.25, Netrom, etc. Other than auditing your code changes, can you tell me what you're changing? I've been attempting to find who / where does regression tests for the Linus

[PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-26 Thread Gustavo A. R. Silva
The aim of this patchset is firstly to refactor code in nr_route.c in order to make it easier to read and maintain and, secondly, to mark some expected switch fall-throughs in preparation to enabling -Wimplicit-fallthrough. I have to mention that I did not implement any unit test. If someone has