Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-09 Thread Jason Wang
On 2019/9/10 上午10:31, Yang Yingliang wrote:   if (!(tun->flags & IFF_PERSIST) && -    tun->dev->reg_state == NETREG_REGISTERED) +    tun->dev->reg_state == NETREG_REGISTERED) { +    tun->flags &= ~TUN_DEV_REGISTERED; As I said for previous vers

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-09 Thread Yang Yingliang
On 2019/9/5 11:10, Jason Wang wrote: On 2019/9/5 上午10:03, Yang Yingliang wrote: On 2019/9/3 18:50, Jason Wang wrote: - Original Message - On 2019/9/3 14:06, Jason Wang wrote: On 2019/9/3 下午1:42, Yang Yingliang wrote: On 2019/9/3 11:03, Jason Wang wrote: On 2019/9/3 上午9:45, Yang

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-04 Thread Jason Wang
On 2019/9/5 上午10:03, Yang Yingliang wrote: > > > On 2019/9/3 18:50, Jason Wang wrote: >> >> - Original Message - >>> >>> On 2019/9/3 14:06, Jason Wang wrote: On 2019/9/3 下午1:42, Yang Yingliang wrote: > > On 2019/9/3 11:03, Jason Wang wrote: >> On 2019/9/3 上午9:45, Yang Ying

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-04 Thread Yang Yingliang
On 2019/9/3 18:50, Jason Wang wrote: - Original Message - On 2019/9/3 14:06, Jason Wang wrote: On 2019/9/3 下午1:42, Yang Yingliang wrote: On 2019/9/3 11:03, Jason Wang wrote: On 2019/9/3 上午9:45, Yang Yingliang wrote: On 2019/9/2 13:32, Jason Wang wrote: On 2019/8/23 下午5:36, Ya

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-03 Thread Jason Wang
- Original Message - > > > On 2019/9/3 14:06, Jason Wang wrote: > > > > On 2019/9/3 下午1:42, Yang Yingliang wrote: > >> > >> > >> On 2019/9/3 11:03, Jason Wang wrote: > >>> > >>> On 2019/9/3 上午9:45, Yang Yingliang wrote: > > > On 2019/9/2 13:32, Jason Wang wrote: > >

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-03 Thread Yang Yingliang
On 2019/9/3 14:06, Jason Wang wrote: On 2019/9/3 下午1:42, Yang Yingliang wrote: On 2019/9/3 11:03, Jason Wang wrote: On 2019/9/3 上午9:45, Yang Yingliang wrote: On 2019/9/2 13:32, Jason Wang wrote: On 2019/8/23 下午5:36, Yang Yingliang wrote: On 2019/8/23 11:05, Jason Wang wrote: ---

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-02 Thread Jason Wang
On 2019/9/3 下午1:42, Yang Yingliang wrote: On 2019/9/3 11:03, Jason Wang wrote: On 2019/9/3 上午9:45, Yang Yingliang wrote: On 2019/9/2 13:32, Jason Wang wrote: On 2019/8/23 下午5:36, Yang Yingliang wrote: On 2019/8/23 11:05, Jason Wang wrote: - Original Message - On 2019/8/22

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-02 Thread Yang Yingliang
On 2019/9/3 11:03, Jason Wang wrote: On 2019/9/3 上午9:45, Yang Yingliang wrote: On 2019/9/2 13:32, Jason Wang wrote: On 2019/8/23 下午5:36, Yang Yingliang wrote: On 2019/8/23 11:05, Jason Wang wrote: - Original Message - On 2019/8/22 14:07, Yang Yingliang wrote: On 2019/8/22

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-02 Thread Jason Wang
On 2019/9/3 上午9:45, Yang Yingliang wrote: On 2019/9/2 13:32, Jason Wang wrote: On 2019/8/23 下午5:36, Yang Yingliang wrote: On 2019/8/23 11:05, Jason Wang wrote: - Original Message - On 2019/8/22 14:07, Yang Yingliang wrote: On 2019/8/22 10:13, Jason Wang wrote: On 2019/8/20

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-02 Thread Yang Yingliang
On 2019/9/2 13:32, Jason Wang wrote: On 2019/8/23 下午5:36, Yang Yingliang wrote: On 2019/8/23 11:05, Jason Wang wrote: - Original Message - On 2019/8/22 14:07, Yang Yingliang wrote: On 2019/8/22 10:13, Jason Wang wrote: On 2019/8/20 上午10:28, Jason Wang wrote: On 2019/8/20 上午9

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-09-01 Thread Jason Wang
On 2019/8/23 下午5:36, Yang Yingliang wrote: On 2019/8/23 11:05, Jason Wang wrote: - Original Message - On 2019/8/22 14:07, Yang Yingliang wrote: On 2019/8/22 10:13, Jason Wang wrote: On 2019/8/20 上午10:28, Jason Wang wrote: On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yin

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-23 Thread Yang Yingliang
On 2019/8/23 11:05, Jason Wang wrote: - Original Message - On 2019/8/22 14:07, Yang Yingliang wrote: On 2019/8/22 10:13, Jason Wang wrote: On 2019/8/20 上午10:28, Jason Wang wrote: On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-22 Thread Jason Wang
- Original Message - > > > On 2019/8/22 14:07, Yang Yingliang wrote: > > > > > > On 2019/8/22 10:13, Jason Wang wrote: > >> > >> On 2019/8/20 上午10:28, Jason Wang wrote: > >>> > >>> On 2019/8/20 上午9:25, David Miller wrote: > From: Yang Yingliang > Date: Mon, 19 Aug 2019 21:31:

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-22 Thread Yang Yingliang
On 2019/8/22 14:07, Yang Yingliang wrote: On 2019/8/22 10:13, Jason Wang wrote: On 2019/8/20 上午10:28, Jason Wang wrote: On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 Call tun_attach() after register_netdevice() to make sure tfile-

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-21 Thread Yang Yingliang
On 2019/8/22 10:13, Jason Wang wrote: On 2019/8/20 上午10:28, Jason Wang wrote: On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 Call tun_attach() after register_netdevice() to make sure tfile->tun is not published until the netdevice is

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-21 Thread Jason Wang
On 2019/8/20 上午10:28, Jason Wang wrote: On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 Call tun_attach() after register_netdevice() to make sure tfile->tun is not published until the netdevice is registered. So the read/write thread can

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-19 Thread Jason Wang
On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 Call tun_attach() after register_netdevice() to make sure tfile->tun is not published until the netdevice is registered. So the read/write thread can not use the tun pointer that may freed by

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-19 Thread David Miller
From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 > Call tun_attach() after register_netdevice() to make sure tfile->tun > is not published until the netdevice is registered. So the read/write > thread can not use the tun pointer that may freed by free_netdev(). > (The tun and dev pointe

[PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-19 Thread Yang Yingliang
I got a UAF repport in tun driver when doing fuzzy test: [ 466.269490] == [ 466.271792] BUG: KASAN: use-after-free in tun_chr_read_iter+0x2ca/0x2d0 [ 466.271806] Read of size 8 at addr 888372139250 by task tun-test/2699 [ 466