Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-09-21 Thread Geert Uytterhoeven
On Wed, Sep 16, 2020 at 11:31 AM Geert Uytterhoeven wrote: > On Thu, Aug 20, 2020 at 2:55 PM Yuusuke Ashizuka wrote: > > When this driver is built as a module, I cannot rmmod it after insmoding > > it. > > This is because that this driver calls ravb_mdio_init() at the time of > > probe, and modul

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-09-16 Thread Geert Uytterhoeven
Hi Ashizuka-san, On Thu, Aug 20, 2020 at 2:55 PM Yuusuke Ashizuka wrote: > When this driver is built as a module, I cannot rmmod it after insmoding > it. > This is because that this driver calls ravb_mdio_init() at the time of > probe, and module->refcnt is incremented by alloc_mdio_bitbang() cal

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-24 Thread David Miller
From: Yuusuke Ashizuka Date: Thu, 20 Aug 2020 18:43:07 +0900 > When this driver is built as a module, I cannot rmmod it after insmoding > it. > This is because that this driver calls ravb_mdio_init() at the time of > probe, and module->refcnt is incremented by alloc_mdio_bitbang() called > after

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-20 Thread David Miller
From: Yuusuke Ashizuka Date: Thu, 20 Aug 2020 18:43:07 +0900 > When this driver is built as a module, I cannot rmmod it after insmoding > it. > This is because that this driver calls ravb_mdio_init() at the time of > probe, and module->refcnt is incremented by alloc_mdio_bitbang() called > after

[PATCH v3] ravb: Fixed to be able to unload modules

2020-08-20 Thread Yuusuke Ashizuka
When this driver is built as a module, I cannot rmmod it after insmoding it. This is because that this driver calls ravb_mdio_init() at the time of probe, and module->refcnt is incremented by alloc_mdio_bitbang() called after that. Therefore, even if ifup is not performed, the driver is in use and

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-20 Thread Sergei Shtylyov
On 8/20/20 3:29 PM, Sergei Shtylyov wrote: >Also, s/Fixed/fix/ in the subject. Nearly missed it. :-) And overall, I'd call the patch "ravb: fix module unloading". MBR, Sergei

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-20 Thread Sergei Shtylyov
Also, s/Fixed/fix/ in the subject. Nearly missed it. :-)

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-08-20 Thread Sergei Shtylyov
On 20.08.2020 12:43, Yuusuke Ashizuka wrote: When this driver is built as a module, I cannot rmmod it after insmoding it. This is because that this driver calls ravb_mdio_init() at the time of "That" not needed here at all; perhaps can be fixed while applying... probe, and module->refcnt