Re: [PATCH v3] net: macb driver, check for SKBTX_HW_TSTAMP

2019-04-08 Thread Paul Thomas
On Mon, Apr 8, 2019 at 1:04 PM David Miller wrote: > > From: Paul Thomas > Date: Mon, 8 Apr 2019 09:20:47 -0400 > > > + if (unlikely(skb_shinfo(skb)->tx_flags & > > SKBTX_HW_TSTAMP) && > > + gem_ptp_do_txstamp(queue, skb, desc) >

Re: [PATCH v3] net: macb driver, check for SKBTX_HW_TSTAMP

2019-04-08 Thread David Miller
From: Paul Thomas Date: Mon, 8 Apr 2019 09:20:47 -0400 > + if (unlikely(skb_shinfo(skb)->tx_flags & > SKBTX_HW_TSTAMP) && > + gem_ptp_do_txstamp(queue, skb, desc) == > 0) { The second line should start precisely at the first colu

[PATCH v3] net: macb driver, check for SKBTX_HW_TSTAMP

2019-04-08 Thread Paul Thomas
Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been enabled for this skb. It does fix the issue where normal socks that aren't expecting a timestamp will not wake up on select, but when a user does want a SOF_TIMESTAMPING_TX_HARDWARE it does work. Signed-off-by: Paul Thomas ---