Re: [PATCH v3] net/irda: fix lockdep annotation

2017-02-17 Thread David Miller
From: Dmitry Vyukov Date: Fri, 17 Feb 2017 22:13:58 +0100 > On Fri, Jan 20, 2017 at 11:53 PM, Dmitry Vyukov wrote: >> On Thu, Jan 19, 2017 at 5:27 PM, David Miller wrote: >>> From: Dmitry Vyukov >>> Date: Thu, 19 Jan 2017 11:05:36 +0100 >>> Thanks for looking into it! This particular issu

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-02-17 Thread Dmitry Vyukov
On Fri, Jan 20, 2017 at 11:53 PM, Dmitry Vyukov wrote: > On Thu, Jan 19, 2017 at 5:27 PM, David Miller wrote: >> From: Dmitry Vyukov >> Date: Thu, 19 Jan 2017 11:05:36 +0100 >> >>> Thanks for looking into it! This particular issue bothers my fuzzers >>> considerably. I agree that removing recurs

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-01-20 Thread Dmitry Vyukov
On Thu, Jan 19, 2017 at 5:27 PM, David Miller wrote: > From: Dmitry Vyukov > Date: Thu, 19 Jan 2017 11:05:36 +0100 > >> Thanks for looking into it! This particular issue bothers my fuzzers >> considerably. I agree that removing recursion is better. >> So do how we proceed? Will you mail this as a

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-01-19 Thread David Miller
From: Dmitry Vyukov Date: Thu, 19 Jan 2017 11:05:36 +0100 > Thanks for looking into it! This particular issue bothers my fuzzers > considerably. I agree that removing recursion is better. > So do how we proceed? Will you mail this as a real patch? Someone needs to test this: diff --git a/net/ir

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-01-19 Thread Dmitry Vyukov
On Thu, Jan 19, 2017 at 11:05 AM, Dmitry Vyukov wrote: > On Tue, Jan 17, 2017 at 9:19 PM, David Miller wrote: >> From: Dmitry Vyukov >> Date: Mon, 16 Jan 2017 22:10:52 +0100 >> >>> The current annotation uses a global variable as recursion counter. >>> The variable is not atomic nor protected wi

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-01-19 Thread Dmitry Vyukov
On Tue, Jan 17, 2017 at 9:19 PM, David Miller wrote: > From: Dmitry Vyukov > Date: Mon, 16 Jan 2017 22:10:52 +0100 > >> The current annotation uses a global variable as recursion counter. >> The variable is not atomic nor protected with a mutex, but mutated >> by multiple threads. This causes loc

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-01-17 Thread David Miller
From: Dmitry Vyukov Date: Mon, 16 Jan 2017 22:10:52 +0100 > The current annotation uses a global variable as recursion counter. > The variable is not atomic nor protected with a mutex, but mutated > by multiple threads. This causes lockdep bug reports episodically: > > BUG: looking up invalid su

[PATCH v3] net/irda: fix lockdep annotation

2017-01-16 Thread Dmitry Vyukov
The current annotation uses a global variable as recursion counter. The variable is not atomic nor protected with a mutex, but mutated by multiple threads. This causes lockdep bug reports episodically: BUG: looking up invalid subclass: 4294967295 ... _raw_spin_lock_irqsave_nested+0x120/0x180 hashb