Re: [PATCH v3] coding-style: Clarify the expectations around bool

2019-01-07 Thread Jason Gunthorpe
On Mon, Jan 07, 2019 at 04:38:50PM -0800, Joe Perches wrote: > On Mon, 2019-01-07 at 16:25 -0700, Jason Gunthorpe wrote: > > On Mon, Jan 07, 2019 at 02:10:22PM -0800, Joe Perches wrote: > > > On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote: > > > > There has been some confusion since check

Re: [PATCH v3] coding-style: Clarify the expectations around bool

2019-01-07 Thread Joe Perches
On Mon, 2019-01-07 at 16:25 -0700, Jason Gunthorpe wrote: > On Mon, Jan 07, 2019 at 02:10:22PM -0800, Joe Perches wrote: > > On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote: > > > There has been some confusion since checkpatch started warning about bool > > > use in structures, and people

Re: [PATCH v3] coding-style: Clarify the expectations around bool

2019-01-07 Thread Jason Gunthorpe
On Mon, Jan 07, 2019 at 02:10:22PM -0800, Joe Perches wrote: > On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote: > > There has been some confusion since checkpatch started warning about bool > > use in structures, and people have been avoiding using it. > > > > Many people feel there is st

Re: [PATCH v3] coding-style: Clarify the expectations around bool

2019-01-07 Thread Bart Van Assche
On Mon, 2019-01-07 at 14:10 -0800, Joe Perches wrote: > On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote: > > There has been some confusion since checkpatch started warning about bool > > use in structures, and people have been avoiding using it. > > > > Many people feel there is still a l

Re: [PATCH v3] coding-style: Clarify the expectations around bool

2019-01-07 Thread Joe Perches
On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote: > There has been some confusion since checkpatch started warning about bool > use in structures, and people have been avoiding using it. > > Many people feel there is still a legitimate place for bool in structures, > so provide some guidan

[PATCH v3] coding-style: Clarify the expectations around bool

2019-01-07 Thread Jason Gunthorpe
There has been some confusion since checkpatch started warning about bool use in structures, and people have been avoiding using it. Many people feel there is still a legitimate place for bool in structures, so provide some guidance on bool usage derived from the entire thread that spawned the che