Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-30 Thread Nicolas Dichtel
Le 30/06/2020 à 19:33, Jakub Kicinski a écrit : > On Tue, 30 Jun 2020 17:51:41 +0200 Nicolas Dichtel wrote: >> Le 30/06/2020 à 08:22, Jakub Kicinski a écrit : >> [snip] >>> My understanding is that for a while now tunnels are not supposed to use >>> dev->hard_header_len to reserve skb space, and us

Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-30 Thread Jakub Kicinski
On Tue, 30 Jun 2020 17:51:41 +0200 Nicolas Dichtel wrote: > Le 30/06/2020 à 08:22, Jakub Kicinski a écrit : > [snip] > > My understanding is that for a while now tunnels are not supposed to use > > dev->hard_header_len to reserve skb space, and use dev->needed_headroom, > > instead. sit uses hard_

Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-30 Thread Jakub Kicinski
On Tue, 30 Jun 2020 12:21:14 +0200 Oliver Herms wrote: > On 30.06.20 08:22, Jakub Kicinski wrote: > > On Fri, 26 Jun 2020 00:44:35 +0200 Oliver Herms wrote: > >> The calculation of the effective tunnel mtu, that is used to create > >> mtu exceptions if necessary, is currently not done correctly.

Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-30 Thread Nicolas Dichtel
Le 30/06/2020 à 08:22, Jakub Kicinski a écrit : [snip] > My understanding is that for a while now tunnels are not supposed to use > dev->hard_header_len to reserve skb space, and use dev->needed_headroom, > instead. sit uses hard_header_len and doesn't even copy needed_headroom > of the lower devi

Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-30 Thread Oliver Herms
On 30.06.20 08:22, Jakub Kicinski wrote: > On Fri, 26 Jun 2020 00:44:35 +0200 Oliver Herms wrote: >> The calculation of the effective tunnel mtu, that is used to create >> mtu exceptions if necessary, is currently not done correctly. This >> leads to unnecessary entries in the IPv6 route cache for

Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-29 Thread Jakub Kicinski
On Fri, 26 Jun 2020 00:44:35 +0200 Oliver Herms wrote: > The calculation of the effective tunnel mtu, that is used to create > mtu exceptions if necessary, is currently not done correctly. This > leads to unnecessary entries in the IPv6 route cache for any > packet send through the tunnel. > > The

[PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-25 Thread Oliver Herms
The calculation of the effective tunnel mtu, that is used to create mtu exceptions if necessary, is currently not done correctly. This leads to unnecessary entries in the IPv6 route cache for any packet send through the tunnel. The root cause is, that "dev->hard_header_len" is subtracted from the