Re: [PATCH v2.2 04/22] fjes: platform_driver's .probe and .remove routine

2015-08-20 Thread David Miller
From: Taku Izumi Date: Thu, 20 Aug 2015 17:46:08 +0900 > + > +err_register: > + fjes_hw_exit(&adapter->hw); > +err_hw_init: > +err_sw_init: > + free_netdev(netdev); > +err_alloc_netdev: > + return err; Having multiple code labels in the same exact spot is suboptimal. Instead, name t

[PATCH v2.2 04/22] fjes: platform_driver's .probe and .remove routine

2015-08-20 Thread Taku Izumi
This patch implements platform_driver's .probe and .remove routine, and also adds board specific private data structure. This driver registers net_device at platform_driver's .probe routine and unregisters net_device at its .remove routine. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h