Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Jakub Kicinski
On Mon, 1 Mar 2021 19:02:51 +0200 Vladimir Oltean wrote: > On Mon, Mar 01, 2021 at 05:26:53PM +0100, Markus Blöchl wrote: > > The main problem here could also just be that almost everybody _thinks_ > > that promiscuity means receiving all frames and no one is aware of the > > standards definition.

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Vladimir Oltean
On Mon, Mar 01, 2021 at 05:26:53PM +0100, Markus Blöchl wrote: > The main problem here could also just be that almost everybody _thinks_ > that promiscuity means receiving all frames and no one is aware of the > standards definition. > In fact, I can't blame them, as the standard is hard to come by

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Markus Blöchl
On Mon, Mar 01, 2021 at 05:08:52PM +0200, Vladimir Oltean wrote: > On Mon, Mar 01, 2021 at 03:36:15PM +0100, Michael Walle wrote: > > Ok, I see, so your proposed behavior is backed by the standards. But > > OTOH there was a summary by Markus of the behavior of other drivers: > > https://lore.kernel

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Vladimir Oltean
On Mon, Mar 01, 2021 at 03:36:15PM +0100, Michael Walle wrote: > Ok, I see, so your proposed behavior is backed by the standards. But > OTOH there was a summary by Markus of the behavior of other drivers: > https://lore.kernel.org/netdev/20201119153751.ix73o5h4n6dgv...@ipetronik.com/ > And a conclu

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Michael Walle
Am 2021-02-28 23:48, schrieb Vladimir Oltean: On Sat, Feb 27, 2021 at 02:18:20PM +0100, Michael Walle wrote: Am 2021-02-27 01:16, schrieb Vladimir Oltean: > On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: > > On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > > > On Fri,

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-28 Thread Vladimir Oltean
On Sat, Feb 27, 2021 at 02:18:20PM +0100, Michael Walle wrote: > Am 2021-02-27 01:16, schrieb Vladimir Oltean: > > On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: > > > On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > > > > On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-27 Thread Michael Walle
Am 2021-02-27 01:16, schrieb Vladimir Oltean: On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub Kicinski wrote: > > I don't understand what you're fixing tho. > > > > Are we

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Vladimir Oltean
On Fri, Feb 26, 2021 at 04:45:19PM -0800, Jakub Kicinski wrote: > I see, so this is indeed of practical importance to NXP. > > Would you mind re-spinning with an expanded justification? Sure, I'll do that tomorrow. Thanks.

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Jakub Kicinski
On Sat, 27 Feb 2021 02:16:51 +0200 Vladimir Oltean wrote: > On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: > > On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > > > What I'm fixing is unexpected behavior, according to the applicable > > > standards I could find. If I do

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Vladimir Oltean
On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: > On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > > On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub Kicinski wrote: > > > I don't understand what you're fixing tho. > > > > > > Are we trying to establish vlan-filter-on as t

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Jakub Kicinski
On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub Kicinski wrote: > > I don't understand what you're fixing tho. > > > > Are we trying to establish vlan-filter-on as the expected behavior? > > What I'm fixing is unexpected behavior, accor

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Vladimir Oltean
On Fri, Feb 26, 2021 at 03:28:36PM -0800, Jakub Kicinski wrote: > I don't understand what you're fixing tho. > > Are we trying to establish vlan-filter-on as the expected behavior? What I'm fixing is unexpected behavior, according to the applicable standards I could find. If I don't mark this chan

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 14:18:34 +0200 Vladimir Oltean wrote: > Quoting from the blamed commit: > > In promiscuous mode, it is more intuitive that all traffic is received, > including VLAN tagged traffic. It appears that it is necessary to set > the flag in PSIPVMR for that to be the case,

[PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean Quoting from the blamed commit: In promiscuous mode, it is more intuitive that all traffic is received, including VLAN tagged traffic. It appears that it is necessary to set the flag in PSIPVMR for that to be the case, so VLAN promiscuous mode is also tempor