Re: [PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-19 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 03:26:41PM +0200, Cornelia Huck wrote: > On Thu, 19 Apr 2018 08:30:49 +0300 > "Michael S. Tsirkin" wrote: > > > Programming vids (adding or removing them) still passes > > guest-endian values in the DMA buffer. That's wrong > > if guest is big-endian and when virtio 1 is e

Re: [PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-19 Thread Cornelia Huck
On Thu, 19 Apr 2018 08:30:49 +0300 "Michael S. Tsirkin" wrote: > Programming vids (adding or removing them) still passes > guest-endian values in the DMA buffer. That's wrong > if guest is big-endian and when virtio 1 is enabled. > > Note: this is on top of a previous patch: > virtio_net:

Re: [PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-19 Thread Jason Wang
On 2018年04月19日 13:30, Michael S. Tsirkin wrote: Programming vids (adding or removing them) still passes guest-endian values in the DMA buffer. That's wrong if guest is big-endian and when virtio 1 is enabled. Note: this is on top of a previous patch: virtio_net: split out ctrl buffer

[PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-18 Thread Michael S. Tsirkin
Programming vids (adding or removing them) still passes guest-endian values in the DMA buffer. That's wrong if guest is big-endian and when virtio 1 is enabled. Note: this is on top of a previous patch: virtio_net: split out ctrl buffer Fixes: 9465a7a6f ("virtio_net: enable v1.0 support")