Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 17:26:03+0200, Alexandre Belloni wrote: > On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > > is in a race with the TX timestamp IRQ, which checks that queue trying > > to ma

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

Re: [PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-18 Thread Alexandre Belloni
On 18/09/2020 04:07:23+0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It > is in a race with the TX timestamp IRQ, which checks that queue trying > to match the timestamp with the skb by the ts_id. The skb should be > a

[PATCH v2 net 1/8] net: mscc: ocelot: fix race condition with TX timestamping

2020-09-17 Thread Vladimir Oltean
From: Vladimir Oltean The TX-timestampable skb is added late to the ocelot_port->tx_skbs. It is in a race with the TX timestamp IRQ, which checks that queue trying to match the timestamp with the skb by the ts_id. The skb should be added to the queue before the IRQ can fire. Fixes: 4e3b0468e6d7