Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

2016-06-14 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> -name = info->name; >> +dev_info(dev, "switch 0x%x detected: %s, revision %u\n", prod_num, >> + info->name, rev); >> >> -ps = devm_kzalloc(dsa_dev, sizeof(*ps), GFP_KERNEL); >> +ps = devm_kzalloc(dev, sizeof(*ps), GFP_KERNEL); >>

Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:50PM -0400, Vivien Didelot wrote: > Extract the allocation and switch ID reading code used by both legacy > and new probing into an helper function which uses a info structure to > describe how to access the switch ID register. > > Signed-off-by: Vivien Didelot > ---

[PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

2016-06-14 Thread Vivien Didelot
Extract the allocation and switch ID reading code used by both legacy and new probing into an helper function which uses a info structure to describe how to access the switch ID register. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 74 -