Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping

2016-07-18 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> +/* Indirect write to single pointer-data register with an Update bit */ >> +static int mv88e6xxx_update_write(struct mv88e6xxx_chip *chip, >> + int addr, int reg, u16 update) > > Hi Vivien > > I don't think mv88e6xxx_update_read() m

Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping

2016-07-18 Thread Andrew Lunn
> +/* Indirect write to single pointer-data register with an Update bit */ > +static int mv88e6xxx_update_write(struct mv88e6xxx_chip *chip, > + int addr, int reg, u16 update) Hi Vivien I don't think mv88e6xxx_update_read() makes any sense? Can we just infer write? C

[PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping

2016-07-18 Thread Vivien Didelot
The Device Mapping register is an indirect table access. Provide helpers to access this table and explicit the checking of the new DSA_RTABLE_NONE routing table value. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 76 1 file change