> > Can you clarify what is poor and what would be better?
> > For example, should I change "X != 0" to "X ? true : false".
>
> Look at this:
> lan743x_ptp_tx_timestamp_skb(tx->adapter,
>buffer_info->skb,
>
On Wed, Jul 18, 2018 at 08:04:08PM +, bryan.whiteh...@microchip.com wrote:
> Thank you for your detailed feedback. I'm working on it now, but I feel it
> will take a little extra time to complete. Therefor I'm planning to remove
> PTP support from this patch series, and resubmit it in a new p
-Original Message-
> From: Richard Cochran [mailto:richardcoch...@gmail.com]
> Sent: Thursday, July 12, 2018 11:32 PM
> To: Bryan Whitehead - C21958
> Cc: da...@davemloft.net; netdev@vger.kernel.org; UNGLinuxDriver
>
> Subject: Re: [PATCH v2 net-next 9/9] lan743x: Add PTP sup
On Thu, Jul 12, 2018 at 03:05:06PM -0400, Bryan Whitehead wrote:
> +static int lan743x_ethtool_get_ts_info(struct net_device *netdev,
> +struct ethtool_ts_info *ts_info)
> +{
> + struct lan743x_adapter *adapter = netdev_priv(netdev);
> +
> + ts_info->so_t
PTP support includes:
Ingress, and egress timestamping.
PTP clock support
Pulse per second output on GPIO
Signed-off-by: Bryan Whitehead
---
drivers/net/ethernet/microchip/Makefile |2 +-
drivers/net/ethernet/microchip/lan743x_ethtool.c | 28 +
drivers/net/ethernet/mic
