Re: [PATCH v2 net-next 6/8] ionic: flatten calls to ionic_lif_rx_mode

2020-11-06 Thread Shannon Nelson
On 11/6/20 1:33 PM, Saeed Mahameed wrote: On Thu, 2020-11-05 at 16:12 -0800, Shannon Nelson wrote: The _ionic_lif_rx_mode() is only used once and really doesn't need to be broken out. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 38 - --

Re: [PATCH v2 net-next 6/8] ionic: flatten calls to ionic_lif_rx_mode

2020-11-06 Thread Saeed Mahameed
On Thu, 2020-11-05 at 16:12 -0800, Shannon Nelson wrote: > The _ionic_lif_rx_mode() is only used once and really doesn't > need to be broken out. > > Signed-off-by: Shannon Nelson > --- > .../net/ethernet/pensando/ionic/ionic_lif.c | 38 - > -- > 1 file changed, 16 insertions(+

Re: [PATCH v2 net-next 6/8] ionic: flatten calls to ionic_lif_rx_mode

2020-11-06 Thread Shannon Nelson
On 11/6/20 9:03 AM, Jakub Kicinski wrote: On Thu, 5 Nov 2020 16:12:18 -0800 Shannon Nelson wrote: + work = kzalloc(sizeof(*work), GFP_ATOMIC); + if (!work) { + netdev_err(lif->netdev, "%s OOM\n", __func__); +

Re: [PATCH v2 net-next 6/8] ionic: flatten calls to ionic_lif_rx_mode

2020-11-06 Thread Jakub Kicinski
On Thu, 5 Nov 2020 16:12:18 -0800 Shannon Nelson wrote: > + work = kzalloc(sizeof(*work), GFP_ATOMIC); > + if (!work) { > + netdev_err(lif->netdev, "%s OOM\n", __func__); > + return; > +

[PATCH v2 net-next 6/8] ionic: flatten calls to ionic_lif_rx_mode

2020-11-05 Thread Shannon Nelson
The _ionic_lif_rx_mode() is only used once and really doesn't need to be broken out. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 38 --- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic