Re: [PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

2017-08-02 Thread Dave Watson
On 08/01/17 08:18 PM, Tom Herbert wrote: > > -static int tls_init(struct sock *sk) > +static int tls_init(struct sock *sk, char __user *optval, int len) > { > - struct inet_connection_sock *icsk = inet_csk(sk); > struct tls_context *ctx; > int rc = 0; > > @@ -450,7 +449,7 @@ st

Re: [PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

2017-08-02 Thread Tom Herbert
On Wed, Aug 2, 2017 at 11:59 AM, Dave Watson wrote: > On 08/01/17 08:18 PM, Tom Herbert wrote: >> Fix TCP and TLS to use the newer ULP infrastructure in sockets. >> >> Signed-off-by: Tom Herbert >> --- >> Documentation/networking/tls.txt | 6 +- >> include/net/inet_connection_sock.h | 4 --

Re: [PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

2017-08-02 Thread Dave Watson
On 08/01/17 08:18 PM, Tom Herbert wrote: > Fix TCP and TLS to use the newer ULP infrastructure in sockets. > > Signed-off-by: Tom Herbert > --- > Documentation/networking/tls.txt | 6 +- > include/net/inet_connection_sock.h | 4 -- > include/net/tcp.h | 25 --- > incl

Re: [PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

2017-08-02 Thread kbuild test robot
Hi Tom, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/inet-include-net-sock-h-in-inet_common-h/20170802-141113 config: x86_64-rhel-7.2 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the att

[PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

2017-08-01 Thread Tom Herbert
Fix TCP and TLS to use the newer ULP infrastructure in sockets. Signed-off-by: Tom Herbert --- Documentation/networking/tls.txt | 6 +- include/net/inet_connection_sock.h | 4 -- include/net/tcp.h | 25 --- include/net/tls.h | 4 +- net/ipv4/sysctl_