Re: [PATCH v2 net-next 3/4] net: phy: Add Qualcomm QCA807x driver

2021-02-10 Thread Andrew Lunn
> +static int qca807x_psgmii_config(struct phy_device *phydev) > +{ > + struct device_node *node = phydev->mdio.dev.of_node; > + int psgmii_az, tx_amp, ret = 0; > + u32 tx_driver_strength_dt; > + > + /* Workaround to enable AZ transmitting ability */ > + if (of_property_read_boo

Re: [PATCH v2 net-next 3/4] net: phy: Add Qualcomm QCA807x driver

2021-02-10 Thread Andrew Lunn
On Wed, Feb 10, 2021 at 01:55:22PM +0100, Robert Marko wrote: Hi Robert Could you move the GPIO driver into a patch of its own, and Cc: the GPIO maintainer and list for that patch please. Andrew

Re: [PATCH v2 net-next 3/4] net: phy: Add Qualcomm QCA807x driver

2021-02-10 Thread kernel test robot
Hi Robert, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Robert-Marko/Add-support-for-Qualcomm-QCA807x-PHYs/20210210-210217 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git de1d

Re: [PATCH v2 net-next 3/4] net: phy: Add Qualcomm QCA807x driver

2021-02-10 Thread Heiner Kallweit
On 10.02.2021 13:55, Robert Marko wrote: > This adds driver for the Qualcomm QCA8072 and QCA8075 PHY-s. > > They are 2 or 5 port IEEE 802.3 clause 22 compliant > 10BASE-Te, 100BASE-TX and 1000BASE-T PHY-s. > > They feature 2 SerDes, one for PSGMII or QSGMII connection with MAC, > while second one

[PATCH v2 net-next 3/4] net: phy: Add Qualcomm QCA807x driver

2021-02-10 Thread Robert Marko
This adds driver for the Qualcomm QCA8072 and QCA8075 PHY-s. They are 2 or 5 port IEEE 802.3 clause 22 compliant 10BASE-Te, 100BASE-TX and 1000BASE-T PHY-s. They feature 2 SerDes, one for PSGMII or QSGMII connection with MAC, while second one is SGMII for connection to MAC or fiber. Both models