Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Vladimir Oltean
On Tue, Dec 01, 2020 at 10:48:34PM +0100, Tobias Waldekranz wrote: > On Tue, Dec 01, 2020 at 22:04, Vladimir Oltean wrote: > > On Tue, Dec 01, 2020 at 03:29:53PM +0100, Tobias Waldekranz wrote: > >> On Tue, Dec 01, 2020 at 16:03, Vladimir Oltean wrote: > >> > On Mon, Nov 30, 2020 at 03:06:08PM +0

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Tobias Waldekranz
On Tue, Dec 01, 2020 at 22:04, Vladimir Oltean wrote: > On Tue, Dec 01, 2020 at 03:29:53PM +0100, Tobias Waldekranz wrote: >> On Tue, Dec 01, 2020 at 16:03, Vladimir Oltean wrote: >> > On Mon, Nov 30, 2020 at 03:06:08PM +0100, Tobias Waldekranz wrote: >> >> When a LAG joins a bridge, the DSA subs

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Vladimir Oltean
On Tue, Dec 01, 2020 at 03:29:53PM +0100, Tobias Waldekranz wrote: > On Tue, Dec 01, 2020 at 16:03, Vladimir Oltean wrote: > > On Mon, Nov 30, 2020 at 03:06:08PM +0100, Tobias Waldekranz wrote: > >> When a LAG joins a bridge, the DSA subsystem will treat that as each > >> individual port joining t

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Tobias Waldekranz
On Tue, Dec 01, 2020 at 16:03, Vladimir Oltean wrote: > On Mon, Nov 30, 2020 at 03:06:08PM +0100, Tobias Waldekranz wrote: >> When a LAG joins a bridge, the DSA subsystem will treat that as each >> individual port joining the bridge. The driver may look at the port's >> LAG pointer to see if it is

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Tobias Waldekranz
On Tue, Dec 01, 2020 at 15:29, Vladimir Oltean wrote: > On Tue, Dec 01, 2020 at 09:13:57AM +0100, Tobias Waldekranz wrote: >> I completely agree with your analysis. I will remove all the RCU >> primitives in v3. Thank you. > > I expect that this also gives us a simple refcount_t instead of the > s

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Vladimir Oltean
On Mon, Nov 30, 2020 at 03:06:08PM +0100, Tobias Waldekranz wrote: > When a LAG joins a bridge, the DSA subsystem will treat that as each > individual port joining the bridge. The driver may look at the port's > LAG pointer to see if it is associated with any LAG, if that is > required. This is ana

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Vladimir Oltean
On Tue, Dec 01, 2020 at 09:13:57AM +0100, Tobias Waldekranz wrote: > I completely agree with your analysis. I will remove all the RCU > primitives in v3. Thank you. I expect that this also gives us a simple refcount_t instead of the struct kref?

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-12-01 Thread Tobias Waldekranz
On Tue, Dec 01, 2020 at 03:37, Vladimir Oltean wrote: > On Mon, Nov 30, 2020 at 03:06:08PM +0100, Tobias Waldekranz wrote: >> +static void dsa_lag_release(struct kref *refcount) >> +{ >> +struct dsa_lag *lag = container_of(refcount, struct dsa_lag, refcount); >> + >> +rcu_assign_pointer(la

Re: [PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-11-30 Thread Vladimir Oltean
Hi Tobias, On Mon, Nov 30, 2020 at 03:06:08PM +0100, Tobias Waldekranz wrote: > Monitor the following events and notify the driver when: > > - A DSA port joins/leaves a LAG. > - A LAG, made up of DSA ports, joins/leaves a bridge. > - A DSA port in a LAG is enabled/disabled (enabled meaning > "d

[PATCH v2 net-next 2/4] net: dsa: Link aggregation support

2020-11-30 Thread Tobias Waldekranz
Monitor the following events and notify the driver when: - A DSA port joins/leaves a LAG. - A LAG, made up of DSA ports, joins/leaves a bridge. - A DSA port in a LAG is enabled/disabled (enabled meaning "distributing" in 802.3ad LACP terms). Each LAG interface to which a DSA port is attached is