Re: [PATCH v2 net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-29 Thread Jarno Rajahalme
> On Nov 28, 2016, at 11:21 PM, Pravin Shelar wrote: > > On Mon, Nov 28, 2016 at 6:41 PM, Jarno Rajahalme wrote: >> Do not set skb->protocol to be the ethertype of the L3 header, unless >> the packet only has the L3 header. For a non-hardware offloaded VLAN >> frame skb->protocol needs to be o

Re: [PATCH v2 net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-28 Thread Pravin Shelar
On Mon, Nov 28, 2016 at 6:41 PM, Jarno Rajahalme wrote: > Do not set skb->protocol to be the ethertype of the L3 header, unless > the packet only has the L3 header. For a non-hardware offloaded VLAN > frame skb->protocol needs to be one of the VLAN ethertypes. > > Any VLAN offloading is undone on

[PATCH v2 net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-28 Thread Jarno Rajahalme
Do not set skb->protocol to be the ethertype of the L3 header, unless the packet only has the L3 header. For a non-hardware offloaded VLAN frame skb->protocol needs to be one of the VLAN ethertypes. Any VLAN offloading is undone on the OVS netlink interface. Also any VLAN tags added by userspace