Re: [PATCH v2 net-next 10/11] qede: Add basic XDP support

2016-11-29 Thread Daniel Borkmann
On 11/29/2016 06:10 PM, Jakub Kicinski wrote: On Tue, 29 Nov 2016 16:48:50 +0100, Daniel Borkmann wrote: On 11/29/2016 03:47 PM, Yuval Mintz wrote: Add support for the ndo_xdp callback. This patch would support XDP_PASS, XDP_DROP and XDP_ABORTED commands. This also adds a per Rx queue statisti

Re: [PATCH v2 net-next 10/11] qede: Add basic XDP support

2016-11-29 Thread Daniel Borkmann
On 11/29/2016 06:51 PM, Mintz, Yuval wrote: You also need to wrap this under rcu_read_lock() (at least I haven't seen it in your patches) for same reasons as stated in 326fe02d1ed6 ("net/mlx4_en: protect ring->xdp_prog with rcu_read_lock"), as otherwise xdp_prog could disappear underneath you. ml

Re: [PATCH v2 net-next 10/11] qede: Add basic XDP support

2016-11-29 Thread Mintz, Yuval
> > You also need to wrap this under rcu_read_lock() (at least I haven't seen > > it in your patches) for same reasons as stated in 326fe02d1ed6 > > ("net/mlx4_en: > > protect ring->xdp_prog with rcu_read_lock"), as otherwise xdp_prog could > > disappear underneath you. mlx4 and nfp does it correc

Re: [PATCH v2 net-next 10/11] qede: Add basic XDP support

2016-11-29 Thread Jakub Kicinski
On Tue, 29 Nov 2016 16:48:50 +0100, Daniel Borkmann wrote: > On 11/29/2016 03:47 PM, Yuval Mintz wrote: > > Add support for the ndo_xdp callback. This patch would support XDP_PASS, > > XDP_DROP and XDP_ABORTED commands. > > > > This also adds a per Rx queue statistic which counts number of packets

Re: [PATCH v2 net-next 10/11] qede: Add basic XDP support

2016-11-29 Thread Daniel Borkmann
On 11/29/2016 03:47 PM, Yuval Mintz wrote: Add support for the ndo_xdp callback. This patch would support XDP_PASS, XDP_DROP and XDP_ABORTED commands. This also adds a per Rx queue statistic which counts number of packets which didn't reach the stack [due to XDP]. Signed-off-by: Yuval Mintz [

[PATCH v2 net-next 10/11] qede: Add basic XDP support

2016-11-29 Thread Yuval Mintz
Add support for the ndo_xdp callback. This patch would support XDP_PASS, XDP_DROP and XDP_ABORTED commands. This also adds a per Rx queue statistic which counts number of packets which didn't reach the stack [due to XDP]. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h