Re: [PATCH v2 net-next 1/5] ionic: simplify returns in devlink info

2019-09-30 Thread Jakub Kicinski
On Mon, 30 Sep 2019 14:49:16 -0700, Shannon Nelson wrote: > There is no need for a goto in this bit of code. > > Fixes: fbfb8031533c9 ("ionic: Add hardware init and device commands") IMHO the fixes tag is disputable here, since this doesn't even generate a warning. > Signed-off-by: Shannon Nelso

[PATCH v2 net-next 1/5] ionic: simplify returns in devlink info

2019-09-30 Thread Shannon Nelson
There is no need for a goto in this bit of code. Fixes: fbfb8031533c9 ("ionic: Add hardware init and device commands") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/et