Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-11-14 Thread Alexei Starovoitov
On 11/13/16 7:51 PM, David Ahern wrote: On 10/31/16 11:49 AM, Thomas Graf wrote: On 10/31/16 at 06:16pm, Daniel Mack wrote: On 10/31/2016 06:05 PM, David Ahern wrote: On 10/31/16 11:00 AM, Daniel Mack wrote: Yeah, I'm confused too. I changed that name in my v7 from BPF_PROG_TYPE_CGROUP_SOCK t

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-11-13 Thread David Ahern
On 10/31/16 11:49 AM, Thomas Graf wrote: > On 10/31/16 at 06:16pm, Daniel Mack wrote: >> On 10/31/2016 06:05 PM, David Ahern wrote: >>> On 10/31/16 11:00 AM, Daniel Mack wrote: Yeah, I'm confused too. I changed that name in my v7 from BPF_PROG_TYPE_CGROUP_SOCK to BPF_PROG_TYPE_CGROUP_SKB

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread Thomas Graf
On 10/31/16 at 06:16pm, Daniel Mack wrote: > On 10/31/2016 06:05 PM, David Ahern wrote: > > On 10/31/16 11:00 AM, Daniel Mack wrote: > >> Yeah, I'm confused too. I changed that name in my v7 from > >> BPF_PROG_TYPE_CGROUP_SOCK to BPF_PROG_TYPE_CGROUP_SKB on David's > >> (Ahern) request. Why is it

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread Daniel Mack
On 10/31/2016 06:05 PM, David Ahern wrote: > On 10/31/16 11:00 AM, Daniel Mack wrote: >> On 10/31/2016 05:58 PM, David Miller wrote: >>> From: David Ahern Date: Wed, 26 Oct >>> 2016 17:58:38 -0700 >>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 6b62ee9a2f78..7

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread David Ahern
On 10/31/16 11:00 AM, Daniel Mack wrote: > On 10/31/2016 05:58 PM, David Miller wrote: >> From: David Ahern >> Date: Wed, 26 Oct 2016 17:58:38 -0700 >> >>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >>> index 6b62ee9a2f78..73da296c2125 100644 >>> --- a/include/uapi/linux/bpf.

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread Daniel Mack
On 10/31/2016 05:58 PM, David Miller wrote: > From: David Ahern > Date: Wed, 26 Oct 2016 17:58:38 -0700 > >> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >> index 6b62ee9a2f78..73da296c2125 100644 >> --- a/include/uapi/linux/bpf.h >> +++ b/include/uapi/linux/bpf.h >> @@ -98,7

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread David Miller
From: David Ahern Date: Wed, 26 Oct 2016 17:58:38 -0700 > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 6b62ee9a2f78..73da296c2125 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -98,7 +98,7 @@ enum bpf_prog_type { > BPF_PROG_TYPE_TRA

[PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-26 Thread David Ahern
Code move only and rename only; no functional change intended. v2 - fix bpf_prog_run_clear_cb to bpf_prog_run_save_cb as caught by Daniel - rename BPF_PROG_TYPE_CGROUP_SKB and its cg_skb functions to BPF_PROG_TYPE_CGROUP and cgroup Signed-off-by: David Ahern --- include/uapi/linux/bpf.h