Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Lucas Bates
On Mon, Jul 8, 2019 at 1:25 PM Alexander Aring wrote: > > Unless I'm off-base here? > > yes you need to know some python, complex code can be hidden by some > helper functionality I guess. > > I have no problem to let this patch in, it will not harm anything... I think I'm going to pull it for the

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Alexander Aring
Hi, On Mon, Jul 08, 2019 at 12:48:12PM -0400, Lucas Bates wrote: > On Thu, Jul 4, 2019 at 4:21 PM Alexander Aring wrote: > > > why you just use eval() as pattern matching operation and let the user > > define how to declare a matching mechanism instead you introduce another > > static matching s

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Lucas Bates
On Thu, Jul 4, 2019 at 4:21 PM Alexander Aring wrote: > why you just use eval() as pattern matching operation and let the user > define how to declare a matching mechanism instead you introduce another > static matching scheme based on a json description? > > Whereas in eval() you could directly

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-04 Thread Alexander Aring
Hi, On Wed, Jul 03, 2019 at 08:45:00PM -0400, Lucas Bates wrote: > This patch allows tdc to process JSON output to perform secondary > verification of the command under test. If the verifyCmd generates > JSON, one can provide the 'matchJSON' key to process it > instead of a regex. > > matchJSON h

[PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-03 Thread Lucas Bates
This patch allows tdc to process JSON output to perform secondary verification of the command under test. If the verifyCmd generates JSON, one can provide the 'matchJSON' key to process it instead of a regex. matchJSON has two elements: 'path' and 'value'. The 'path' key is a list of integers and