Re: [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup

2018-03-10 Thread kbuild test robot
Hi Brad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Brad-Mouring/net-macb-Reorganize-macb_mii-bringup/20180311-133616 config: i386-randconfig-x012-201810 (attached as .config) compiler: gcc

Re: [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup

2018-03-10 Thread Brad Mouring
Hi Andrew, On Sat, Mar 10, 2018 at 05:17:18PM +0100, Andrew Lunn wrote: > On Fri, Mar 09, 2018 at 04:12:31PM -0600, Brad Mouring wrote: > > The macb mii setup (mii_probe() and mii_init()) previously was > > somewhat interspersed, likely a result of organic growth and hacking. > > Hi Brad > > For

Re: [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup

2018-03-10 Thread Andrew Lunn
On Fri, Mar 09, 2018 at 04:12:31PM -0600, Brad Mouring wrote: > The macb mii setup (mii_probe() and mii_init()) previously was > somewhat interspersed, likely a result of organic growth and hacking. Hi Brad For netdev it is normal to include a cover note for patch series, which explains the big p

[PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup

2018-03-09 Thread Brad Mouring
The macb mii setup (mii_probe() and mii_init()) previously was somewhat interspersed, likely a result of organic growth and hacking. This change moves mii bus registration into mii_init and probing the bus for devices into mii_probe. Signed-off-by: Brad Mouring Suggested-by: Andrew Lunn --- dr