Re: [PATCH v2 net-next 1/2] phy: add phy fixup unregister functions

2016-12-15 Thread Dongpo Li
On 2016/12/14 23:34, woojung@microchip.com wrote: >> I just want to commit the unregister patch and found this patch. Good job! >> But I consider this patch may miss something. >> If one SoC has 2 MAC ports and each port uses the different network driver, >> the 2 drivers may register fixup fo

RE: [PATCH v2 net-next 1/2] phy: add phy fixup unregister functions

2016-12-14 Thread Woojung.Huh
> I just want to commit the unregister patch and found this patch. Good job! > But I consider this patch may miss something. > If one SoC has 2 MAC ports and each port uses the different network driver, > the 2 drivers may register fixup for the same PHY chip with different > "run" function because

Re: [PATCH v2 net-next 1/2] phy: add phy fixup unregister functions

2016-12-14 Thread Dongpo Li
Hi all, On 2016/12/8 4:26, woojung@microchip.com wrote: >>From : Woojung Huh > > Add functions to unregister phy fixup for modules. > > int phy_unregister_fixup(const char *bus_id, u32 phy_uid, u32 phy_uid_mask) > Unregister phy fixup from phy_fixup_list per bus_id, phy_uid & >

[PATCH v2 net-next 1/2] phy: add phy fixup unregister functions

2016-12-07 Thread Woojung.Huh
>From : Woojung Huh Add functions to unregister phy fixup for modules. int phy_unregister_fixup(const char *bus_id, u32 phy_uid, u32 phy_uid_mask) Unregister phy fixup from phy_fixup_list per bus_id, phy_uid & phy_uid_mask int phy_unregister_fixup_for_uid(u32 phy_uid, u32 phy_ui