Re: [PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

2015-09-18 Thread Daniel Borkmann
Hi Jamal, On 09/18/2015 02:13 PM, Jamal Hadi Salim wrote: ... The architecture is about small tools that come together to provide complex processing. ebpf may be the best classifier today - but by no means the only one or guaranteed that nothing better will exist for speficic use cases. Yes, I

Re: [PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

2015-09-18 Thread Jamal Hadi Salim
On 09/17/15 11:19, Alexei Starovoitov wrote: misread as bpf program now executes the actions and bypasses tcf_exts_exec() ? Well, that may be interesting idea for the future, And above is precisely why i raised the concern. You are already bypassing tcf_exts_exec with that patch. It is a big j

Re: [PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

2015-09-18 Thread Jamal Hadi Salim
Hi Daniel, On 09/17/15 09:13, Daniel Borkmann wrote: Hmm, I don't really agree. With cls_bpf you have non-linear classifications as opposed to walking a chain of classifiers: A chain of classifiers is a better description today (non-linear would be an appropriate description before cls_bpf ;-

Re: [PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

2015-09-17 Thread Alexei Starovoitov
On 9/17/15 6:13 AM, Daniel Borkmann wrote: Hi Jamal, On 09/17/2015 02:37 PM, Jamal Hadi Salim wrote: On 09/16/15 02:05, Alexei Starovoitov wrote: From: Daniel Borkmann Often cls_bpf classifier is used with single action drop attached. Optimize this use case and let cls_bpf return both classi

Re: [PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

2015-09-17 Thread Daniel Borkmann
Hi Jamal, On 09/17/2015 02:37 PM, Jamal Hadi Salim wrote: On 09/16/15 02:05, Alexei Starovoitov wrote: From: Daniel Borkmann Often cls_bpf classifier is used with single action drop attached. Optimize this use case and let cls_bpf return both classid and action. For backwards compatibility re

Re: [PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

2015-09-17 Thread Jamal Hadi Salim
On 09/16/15 02:05, Alexei Starovoitov wrote: From: Daniel Borkmann Often cls_bpf classifier is used with single action drop attached. Optimize this use case and let cls_bpf return both classid and action. For backwards compatibility reasons enable this feature under TCA_BPF_FLAG_ACT_DIRECT flag

[PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

2015-09-15 Thread Alexei Starovoitov
From: Daniel Borkmann Often cls_bpf classifier is used with single action drop attached. Optimize this use case and let cls_bpf return both classid and action. For backwards compatibility reasons enable this feature under TCA_BPF_FLAG_ACT_DIRECT flag. Then more interesting programs like the foll