Re: [PATCH v2 net-next 03/12] net: aquantia: add basic ptp_clock callbacks

2019-10-14 Thread Igor Russkikh
Hi Richard, Thanks for your review, will update the patchset after the comments. >> +{ >> +struct aq_ptp_s *aq_ptp = container_of(ptp, struct aq_ptp_s, ptp_info); >> +struct aq_nic_s *aq_nic = aq_ptp->aq_nic; >> + >> +mutex_lock(&aq_nic->fwreq_mutex); > > Here you use a different lo

Re: [PATCH v2 net-next 03/12] net: aquantia: add basic ptp_clock callbacks

2019-10-12 Thread Richard Cochran
On Tue, Oct 08, 2019 at 10:56:40AM +, Igor Russkikh wrote: > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > index d5a28904f708..ba1597bb6eab 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c > +++ b/drivers/net/e

[PATCH v2 net-next 03/12] net: aquantia: add basic ptp_clock callbacks

2019-10-08 Thread Igor Russkikh
From: Egor Pomozov Basic HW functions implemented for adjusting frequency, adjusting time, getting and setting time. Firmware interface for PTP requests and interactions. Enable/disable PTP counters in HW on clock register/unregister Signed-off-by: Egor Pomozov Co-developed-by: Sergey Samoilen