Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

2018-07-18 Thread Dave Taht
In my dreamworld, a packet with a timestamp achieved at rx time on ethX, or via local traffic, would be consistent with the right clock throughout the system and reliably still be there when it goes to ethY. This would save having to timestamp (again) inside the cb block in fq_codel, cake, etc, an

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

2018-07-18 Thread Jesus Sanchez-Palencia
Hi Eric, On 07/16/2018 04:15 PM, Eric Dumazet wrote: > > > On 07/16/2018 02:52 PM, Jesus Sanchez-Palencia wrote: >> Hi Eric, >> >> >> >> On 07/13/2018 10:35 AM, Eric Dumazet wrote: >>> >>> >>> On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: This is done in preparation for the upcomin

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

2018-07-16 Thread Eric Dumazet
On 07/16/2018 02:52 PM, Jesus Sanchez-Palencia wrote: > Hi Eric, > > > > On 07/13/2018 10:35 AM, Eric Dumazet wrote: >> >> >> On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: >>> This is done in preparation for the upcoming time based transmission >>> patchset. Now that skb->tstamp will

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

2018-07-16 Thread Jesus Sanchez-Palencia
Hi Eric, On 07/13/2018 10:35 AM, Eric Dumazet wrote: > > > On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: >> This is done in preparation for the upcoming time based transmission >> patchset. Now that skb->tstamp will be used to hold packet's txtime, >> we must ensure that it is being cl

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

2018-07-13 Thread Eric Dumazet
On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: > This is done in preparation for the upcoming time based transmission > patchset. Now that skb->tstamp will be used to hold packet's txtime, > we must ensure that it is being cleared when traversing namespaces. > Also, doing that from skb_sc

[PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

2018-07-03 Thread Jesus Sanchez-Palencia
This is done in preparation for the upcoming time based transmission patchset. Now that skb->tstamp will be used to hold packet's txtime, we must ensure that it is being cleared when traversing namespaces. Also, doing that from skb_scrub_packet() before the early return would break our feature when