Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-13 Thread Eric Dumazet
On Mon, Feb 13, 2017 at 12:50 AM, Tariq Toukan wrote: > > > MTU is changed from 1500 to 500, with VLAN configured. Thanks, I now see what is happening. mlx4_en_free_rx_buf() needs to clean whole rx_info buffer, not the part between ring->cons & ring->prod, otherwise we still could see garbage l

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-13 Thread Tariq Toukan
On 12/02/2017 6:48 PM, Eric Dumazet wrote: Setup 2: PowerPC [10586.623028] Unable to handle kernel paging request for data at address 0x80251f9001c [10586.623072] Faulting instruction address: 0xc0236fa8 [10586.623081] Oops: Kernel access of bad area, sig: 11 [#1] [10586.623087] SMP

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
On Sun, 2017-02-12 at 23:38 +0100, Jesper Dangaard Brouer wrote: > Just so others understand this: The number of RX queue slots is > indirectly the size of the page-recycle "cache" in this scheme (that > depend on refcnt tricks to see if page can be reused). Note that the page recycle tricks only

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Jesper Dangaard Brouer
On Sun, 12 Feb 2017 12:57:46 -0800 Eric Dumazet wrote: > On Sun, 2017-02-12 at 18:31 +0200, Tariq Toukan wrote: > > On 09/02/2017 6:56 PM, Eric Dumazet wrote: > > >> Default, out of box. > > > Well. Please report : > > > > > > ethtool -l eth0 > > > ethtool -g eth0 > > $ ethtool -g p1p1 > >

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
On Sun, 2017-02-12 at 18:31 +0200, Tariq Toukan wrote: > On 09/02/2017 6:56 PM, Eric Dumazet wrote: > >> Default, out of box. > > Well. Please report : > > > > ethtool -l eth0 > > ethtool -g eth0 > $ ethtool -g p1p1 > Ring parameters for p1p1: > Pre-set maximums: > RX: 8192 > RX Mini:

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Tariq Toukan
On 12/02/2017 5:32 PM, Eric Dumazet wrote: On Sun, Feb 12, 2017 at 7:04 AM, Tariq Toukan wrote: We consistently see this behavior: the higher the BW, the sharper the degradation. This is because the page-cache is of a fixed-size. Any fixed-size page-cache will always meet one of the followi

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
Please Tariq do not send HTML messages, they are not making to netdev mailing list. On Sun, Feb 12, 2017 at 7:55 AM, Tariq Toukan wrote: > > On 09/02/2017 6:43 PM, Tariq Toukan wrote: > > We need to test this series again in our functional and performance > regression systems. > It will be runnin

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Tariq Toukan
On 09/02/2017 6:56 PM, Eric Dumazet wrote: Default, out of box. Well. Please report : ethtool -l eth0 ethtool -g eth0 $ ethtool -g p1p1 Ring parameters for p1p1: Pre-set maximums: RX: 8192 RX Mini:0 RX Jumbo: 0 TX: 8192 Current hardware settings: RX:

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
On Sun, Feb 12, 2017 at 7:04 AM, Tariq Toukan wrote: > > We consistently see this behavior: the higher the BW, the sharper the > degradation. > > This is because the page-cache is of a fixed-size. Any fixed-size page-cache > will always meet one of the following: > 1) Too small to keep the pace w

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-09 Thread Eric Dumazet
On Thu, Feb 9, 2017 at 8:49 AM, Tariq Toukan wrote: > > > On 09/02/2017 6:44 PM, Eric Dumazet wrote: >> >> On Thu, Feb 9, 2017 at 8:41 AM, Tariq Toukan >> wrote: >>> >>> Hi Eric, >>> >>> Thanks again for your series. >>> >>> On 09/02/2017 3:58 PM, Eric Dumazet wrote: >>> >>> As mentioned half a y

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-09 Thread Tariq Toukan
On 09/02/2017 6:44 PM, Eric Dumazet wrote: On Thu, Feb 9, 2017 at 8:41 AM, Tariq Toukan wrote: Hi Eric, Thanks again for your series. On 09/02/2017 3:58 PM, Eric Dumazet wrote: As mentioned half a year ago, we better switch mlx4 driver to order-0 allocations and page recycling. This reduc

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-09 Thread Eric Dumazet
On Thu, Feb 9, 2017 at 8:41 AM, Tariq Toukan wrote: > Hi Eric, > > Thanks again for your series. > > On 09/02/2017 3:58 PM, Eric Dumazet wrote: > > As mentioned half a year ago, we better switch mlx4 driver to order-0 > allocations and page recycling. > > This reduces vulnerability surface thanks

[PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-09 Thread Eric Dumazet
As mentioned half a year ago, we better switch mlx4 driver to order-0 allocations and page recycling. This reduces vulnerability surface thanks to better skb->truesize tracking and provides better performance in most cases. v2 provides an ethtool -S new counter (rx_alloc_pages) and code factoriza