Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-02 Thread Martin KaFai Lau
On Wed, May 31, 2017 at 07:35:18PM -0400, David Miller wrote: > From: Martin KaFai Lau > Date: Wed, 31 May 2017 11:58:54 -0700 > > > This patch series: > > 1) Introduce ID for both bpf_prog and bpf_map. > > 2) Add bpf commands to iterate the prog IDs and map > >IDs of the system. > > 3) Add bp

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-02 Thread David Ahern
On 6/1/17 3:48 PM, Alexei Starovoitov wrote: > You saw patch 7/8, right? Apparently, not close enough. Nothing in the commit message mentioned returning instructions. I skimmed the patch and filled in that GET_INFO was returning just the meta-data.

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread Alexei Starovoitov
On 6/1/17 11:52 AM, David Ahern wrote: On 6/1/17 12:27 PM, Alexei Starovoitov wrote: 'I want to retrieve original instructions' is not a problem. It's a push for 'solution'. Explaining 'why' you want to see original instructions would describe the actual problem. I have explained this. You ar

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread Jakub Kicinski
On Thu, 1 Jun 2017 12:52:28 -0600, David Ahern wrote: > On 6/1/17 12:27 PM, Alexei Starovoitov wrote: > > 'I want to retrieve original instructions' is not a problem. It's a > > push for 'solution'. Explaining 'why' you want to see original > > instructions would describe the actual problem. > >

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread Jakub Kicinski
On Thu, 01 Jun 2017 14:33:36 -0400 (EDT), David Miller wrote: > From: Alexei Starovoitov > Date: Thu, 1 Jun 2017 11:27:56 -0700 > > > Original instructions are not useful for debugging, since they have > > map_fds which can be long gone when program is running, therefore to > > solve introspectio

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread David Miller
From: David Ahern Date: Thu, 1 Jun 2017 12:52:28 -0600 > On 6/1/17 12:27 PM, Alexei Starovoitov wrote: >> 'I want to retrieve original instructions' is not a problem. It's a >> push for 'solution'. Explaining 'why' you want to see original >> instructions would describe the actual problem. > > I

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread David Ahern
On 6/1/17 12:27 PM, Alexei Starovoitov wrote: > 'I want to retrieve original instructions' is not a problem. It's a > push for 'solution'. Explaining 'why' you want to see original > instructions would describe the actual problem. I have explained this. You are creating this hyper-complex almost

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread David Miller
From: Alexei Starovoitov Date: Thu, 1 Jun 2017 11:27:56 -0700 > Original instructions are not useful for debugging, since they have > map_fds which can be long gone when program is running, therefore to > solve introspection problem we need to look into real kernel > instructions. The only possi

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread Alexei Starovoitov
On 6/1/17 10:51 AM, David Ahern wrote: On 6/1/17 11:24 AM, Alexei Starovoitov wrote: what problem are we trying to solve? If we don't agree on the problem, we won't be able to agree on the solution. I want the ability to retrieve the BPF instructions pushed to the kernel. Not just for cgroups

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread David Ahern
On 6/1/17 11:24 AM, Alexei Starovoitov wrote: > > what problem are we trying to solve? > If we don't agree on the problem, we won't be able to agree on the > solution. I want the ability to retrieve the BPF instructions pushed to the kernel. Not just for cgroups and VRF, but everywhere - cgroups,

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread Alexei Starovoitov
On 6/1/17 6:55 AM, David Ahern wrote: On 5/31/17 8:22 PM, Jakub Kicinski wrote: On Wed, 31 May 2017 11:58:54 -0700, Martin KaFai Lau wrote: This patch series: 1) Introduce ID for both bpf_prog and bpf_map. 2) Add bpf commands to iterate the prog IDs and map IDs of the system. 3) Add bpf comm

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-06-01 Thread David Ahern
On 5/31/17 8:22 PM, Jakub Kicinski wrote: > On Wed, 31 May 2017 11:58:54 -0700, Martin KaFai Lau wrote: >> This patch series: >> 1) Introduce ID for both bpf_prog and bpf_map. >> 2) Add bpf commands to iterate the prog IDs and map >>IDs of the system. >> 3) Add bpf commands to get a prog/map fd

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-05-31 Thread Jakub Kicinski
On Wed, 31 May 2017 11:58:54 -0700, Martin KaFai Lau wrote: > This patch series: > 1) Introduce ID for both bpf_prog and bpf_map. > 2) Add bpf commands to iterate the prog IDs and map >IDs of the system. > 3) Add bpf commands to get a prog/map fd from an ID > 4) Add bpf command to get prog/map

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-05-31 Thread David Miller
From: Martin KaFai Lau Date: Wed, 31 May 2017 11:58:54 -0700 > This patch series: > 1) Introduce ID for both bpf_prog and bpf_map. > 2) Add bpf commands to iterate the prog IDs and map >IDs of the system. > 3) Add bpf commands to get a prog/map fd from an ID > 4) Add bpf command to get prog/m

[PATCH v2 net-next 0/8] Introduce bpf ID

2017-05-31 Thread Martin KaFai Lau
This patch series: 1) Introduce ID for both bpf_prog and bpf_map. 2) Add bpf commands to iterate the prog IDs and map IDs of the system. 3) Add bpf commands to get a prog/map fd from an ID 4) Add bpf command to get prog/map info from a fd. The prog/map info is a jump start in this patchset