Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions

2019-04-28 Thread David Ahern
On 4/28/19 11:53 AM, Alexei Starovoitov wrote: > Adding tests as we go along would immensely help too. > Unfortunately afaik there is no test infra to use for it. pcpu routes are the predominant ones used for traffic. We have a number of existing tests in selftests - fib_tests.sh - that exercise

Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions

2019-04-28 Thread David Ahern
On 4/28/19 9:06 AM, Eric Dumazet wrote: > > I would prefer we fix the existing bugs before moving the code around, > otherwise stable teams work is going to be tough. > fair enough. I'll drop the ipv6 patches and re-send just the v4 ones.

Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions

2019-04-28 Thread Alexei Starovoitov
On Sun, Apr 28, 2019 at 8:10 AM Eric Dumazet wrote: > > > > On 4/27/19 7:27 PM, David Ahern wrote: > > From: David Ahern > > > > This series moves IPv4 pcpu cached routes from fib_nh to fib_nh_common > > to make the caches avaialable for IPv6 nexthops (fib6_nh) with IPv4 > > routes. This allows a

Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions

2019-04-28 Thread Eric Dumazet
On 4/27/19 7:27 PM, David Ahern wrote: > From: David Ahern > > This series moves IPv4 pcpu cached routes from fib_nh to fib_nh_common > to make the caches avaialable for IPv6 nexthops (fib6_nh) with IPv4 > routes. This allows a fib6_nh struct to be used with both IPv4 and > and IPv6 routes. >

[PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions

2019-04-27 Thread David Ahern
From: David Ahern This series moves IPv4 pcpu cached routes from fib_nh to fib_nh_common to make the caches avaialable for IPv6 nexthops (fib6_nh) with IPv4 routes. This allows a fib6_nh struct to be used with both IPv4 and and IPv6 routes. In addition pcpu caches and exception entries for IPv6