Re: [PATCH v2 net-next] tcp-tso: do not split TSO packets at retransmit time

2016-04-25 Thread Eric Dumazet
On Mon, 2016-04-25 at 10:39 -0700, Eric Dumazet wrote: > Linux TCP stack painfully segments all TSO/GSO packets before retransmits. > humpf. > Signed-off-by: Eric Dumazet > Acked-by: Yuchung Cheng > --- > include/net/tcp.h | 4 ++-- > net/ipv4/tcp_input.c | 2 +- > net/ipv4/tcp_output

[PATCH v2 net-next] tcp-tso: do not split TSO packets at retransmit time

2016-04-25 Thread Eric Dumazet
Linux TCP stack painfully segments all TSO/GSO packets before retransmits. This was fine back in the days when TSO/GSO were emerging, with their bugs, but we believe the dark age is over. Keeping big packets in write queues, but also in stack traversal has a lot of benefits. - Less memory overhe

Re: [PATCH v2 net-next] tcp-tso: do not split TSO packets at retransmit time

2016-04-24 Thread David Miller
From: Eric Dumazet Date: Thu, 21 Apr 2016 10:55:23 -0700 > Linux TCP stack painfully segments all TSO/GSO packets before retransmits. > > This was fine back in the days when TSO/GSO were emerging, with their > bugs, but we believe the dark age is over. > > Keeping big packets in write queues, b

[PATCH v2 net-next] tcp-tso: do not split TSO packets at retransmit time

2016-04-21 Thread Eric Dumazet
Linux TCP stack painfully segments all TSO/GSO packets before retransmits. This was fine back in the days when TSO/GSO were emerging, with their bugs, but we believe the dark age is over. Keeping big packets in write queues, but also in stack traversal has a lot of benefits. - Less memory overhe