Re: [PATCH v2 net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-27 Thread David Miller
From: Eric Dumazet Date: Tue, 26 Mar 2019 08:34:55 -0700 > My recent patch had at least three problems : > > 1) TX zerocopy wants notification when skb is acknowledged, >thus we need to call skb_zcopy_clear() if the skb is >cached into sk->sk_tx_skb_cache > > 2) Some applications might

Re: [PATCH v2 net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-26 Thread Holger Hoffstätte
On Tue, 26 Mar 2019 08:34:55 -0700, Eric Dumazet wrote: > My recent patch had at least three problems : > > 1) TX zerocopy wants notification when skb is acknowledged, >thus we need to call skb_zcopy_clear() if the skb is >cached into sk->sk_tx_skb_cache > > 2) Some applications might ex

Re: [PATCH v2 net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-26 Thread Soheil Hassas Yeganeh
On Tue, Mar 26, 2019 at 11:35 AM Eric Dumazet wrote: > > My recent patch had at least three problems : > > 1) TX zerocopy wants notification when skb is acknowledged, >thus we need to call skb_zcopy_clear() if the skb is >cached into sk->sk_tx_skb_cache > > 2) Some applications might expec

[PATCH v2 net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-26 Thread Eric Dumazet
My recent patch had at least three problems : 1) TX zerocopy wants notification when skb is acknowledged, thus we need to call skb_zcopy_clear() if the skb is cached into sk->sk_tx_skb_cache 2) Some applications might expect precise EPOLLOUT notifications, so we need to update sk->sk_wme