Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-12 Thread Liviu Dudau
On Wed, Aug 12, 2015 at 04:28:23PM +0100, Stephen Hemminger wrote: > On Wed, 12 Aug 2015 10:30:05 +0100 > Liviu Dudau wrote: > > > On Tue, Aug 11, 2015 at 06:01:32PM +0100, Stephen Hemminger wrote: > > > On Tue, 11 Aug 2015 15:35:56 +0100 > > > Liviu Dudau wrote: > > > > > > > On some embedded

Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-12 Thread Stephen Hemminger
On Wed, 12 Aug 2015 10:30:05 +0100 Liviu Dudau wrote: > On Tue, Aug 11, 2015 at 06:01:32PM +0100, Stephen Hemminger wrote: > > On Tue, 11 Aug 2015 15:35:56 +0100 > > Liviu Dudau wrote: > > > > > On some embedded systems the EEPROM does not contain a valid MAC address. > > > In that case it is b

Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-12 Thread Liviu Dudau
On Tue, Aug 11, 2015 at 06:01:32PM +0100, Stephen Hemminger wrote: > On Tue, 11 Aug 2015 15:35:56 +0100 > Liviu Dudau wrote: > > > On some embedded systems the EEPROM does not contain a valid MAC address. > > In that case it is better to fallback to a generated mac address and > > let init script

Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-12 Thread Liviu Dudau
On Tue, Aug 11, 2015 at 07:56:06PM +0100, Sergei Shtylyov wrote: > Hello. > > On 08/11/2015 05:35 PM, Liviu Dudau wrote: > > > On some embedded systems the EEPROM does not contain a valid MAC address. > > In that case it is better to fallback to a generated mac address and > > let init scripts fi

Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-11 Thread Sergei Shtylyov
Hello. On 08/11/2015 05:35 PM, Liviu Dudau wrote: On some embedded systems the EEPROM does not contain a valid MAC address. In that case it is better to fallback to a generated mac address and let init scripts fix the value later. Reported-by: Liviu Dudau Signed-off-by: Stephen Hemminger [

Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-11 Thread Stephen Hemminger
On Tue, 11 Aug 2015 15:35:56 +0100 Liviu Dudau wrote: > On some embedded systems the EEPROM does not contain a valid MAC address. > In that case it is better to fallback to a generated mac address and > let init scripts fix the value later. > > Reported-by: Liviu Dudau > Signed-off-by: Stephen

[PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-11 Thread Liviu Dudau
On some embedded systems the EEPROM does not contain a valid MAC address. In that case it is better to fallback to a generated mac address and let init scripts fix the value later. Reported-by: Liviu Dudau Signed-off-by: Stephen Hemminger [Changed handcoded setup to use eth_hw_addr_random() inst