Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread David Miller
From: Rouven Czerwinski Date: Thu, 6 Aug 2020 08:49:06 +0200 > Trying to use ktls on a system with 32-bit userspace and 64-bit kernel > results in a EOPNOTSUPP message during sendmsg: > > setsockopt(3, SOL_TLS, TLS_TX, …, 40) = 0 > sendmsg(3, …, msg_flags=0}, 0) = -1 EOPNOTSUPP (Operation n

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Jakub Kicinski
On Fri, 07 Aug 2020 14:27:48 +0200 Rouven Czerwinski wrote: > I just tested on my x86_64 workstation and these specific tests fail > there too, do they only work on 5.8? They were added in 5.8, but I am > running 5.7.11 here. It looks like these failures are not > MSG_CMSG_COMPAT related. > > Pooj

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Rouven Czerwinski
On Fri, 2020-08-07 at 10:26 +0200, Rouven Czerwinski wrote: > On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > > kernel > > > results in a EOPNOTSUPP mes

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Rouven Czerwinski
On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > kernel > > results in a EOPNOTSUPP message during sendmsg: > > > > setsockopt(3, SOL_TLS, TLS_TX, …, 40)

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-06 Thread Jakub Kicinski
On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > Trying to use ktls on a system with 32-bit userspace and 64-bit kernel > results in a EOPNOTSUPP message during sendmsg: > > setsockopt(3, SOL_TLS, TLS_TX, …, 40) = 0 > sendmsg(3, …, msg_flags=0}, 0) = -1 EOPNOTSUPP (Operation not s

[PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-05 Thread Rouven Czerwinski
Trying to use ktls on a system with 32-bit userspace and 64-bit kernel results in a EOPNOTSUPP message during sendmsg: setsockopt(3, SOL_TLS, TLS_TX, …, 40) = 0 sendmsg(3, …, msg_flags=0}, 0) = -1 EOPNOTSUPP (Operation not supported) The tls_sw implementation does strict flag checking and doe