Re: [PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options

2017-11-02 Thread David Miller
From: Tom Herbert Date: Mon, 30 Oct 2017 14:16:00 -0700 > RFC 8200 (IPv6) defines Hop-by-Hop options and Destination options > extension headers. Both of these carry a list of TLVs which is > only limited by the maximum length of the extension header (2048 > bytes). By the spec a host must proces

Re: [PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options

2017-10-30 Thread Eric Dumazet
On Tue, 2017-10-31 at 11:10 +0900, David Miller wrote: > From: Tom Herbert > Date: Mon, 30 Oct 2017 14:16:00 -0700 > > > I wrote a quick test program that floods a whole bunch of these > > packets to a host and sure enough there is substantial time spent > > in ip6_parse_tlv. > ... > > 25.38%

Re: [PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options

2017-10-30 Thread Tom Herbert
On Mon, Oct 30, 2017 at 7:10 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 30 Oct 2017 14:16:00 -0700 > >> I wrote a quick test program that floods a whole bunch of these >> packets to a host and sure enough there is substantial time spent >> in ip6_parse_tlv. > ... >> 25.38% [kern

Re: [PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options

2017-10-30 Thread David Miller
From: Tom Herbert Date: Mon, 30 Oct 2017 14:16:00 -0700 > I wrote a quick test program that floods a whole bunch of these > packets to a host and sure enough there is substantial time spent > in ip6_parse_tlv. ... > 25.38% [kernel][k] __fib6_clean_all > 21.63% [kernel]

[PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options

2017-10-30 Thread Tom Herbert
RFC 8200 (IPv6) defines Hop-by-Hop options and Destination options extension headers. Both of these carry a list of TLVs which is only limited by the maximum length of the extension header (2048 bytes). By the spec a host must process all the TLVs in these options, however these could be used as a