Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-27 Thread David Miller
From: Florian Westphal Date: Thu, 26 Sep 2019 20:37:05 +0200 > Now that we have a 3rd extension, add a new helper that drops the > extension space and use it when we need to scrub an sk_buff. > > At this time, scrubbing clears secpath and bridge netfilter data, but > retains the tc skb extension

Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Eric Dumazet
On 9/26/19 12:09 PM, Florian Westphal wrote: > Eric Dumazet wrote: >>> - secpath_reset(skb); >>> + skb_ext_reset(skb); >>> nf_reset(skb); >>> nf_reset_trace(skb); >> >> >> It is unfortunate nf_reset(skb) will call skb_ext_del(skb, >> SKB_EXT_BRIDGE_NF), >> which is useless after sk

Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Florian Westphal
Eric Dumazet wrote: > > - secpath_reset(skb); > > + skb_ext_reset(skb); > > nf_reset(skb); > > nf_reset_trace(skb); > > > It is unfortunate nf_reset(skb) will call skb_ext_del(skb, SKB_EXT_BRIDGE_NF), > which is useless after skb_ext_reset(skb) > > Maybe time for a nf_ct_reset() he

Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Eric Dumazet
On 9/26/19 11:37 AM, Florian Westphal wrote: > Now that we have a 3rd extension, add a new helper that drops the > extension space and use it when we need to scrub an sk_buff. > > } > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index f12e8a050edb..01d65206f4fb 100644 > --- a/net/core

[PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

2019-09-26 Thread Florian Westphal
Now that we have a 3rd extension, add a new helper that drops the extension space and use it when we need to scrub an sk_buff. At this time, scrubbing clears secpath and bridge netfilter data, but retains the tc skb extension, after this patch all three get cleared. NAPI reuse/free assumes we can