Re: [PATCH v2 net] net_sched: prio: insure proper transactional behavior

2016-06-15 Thread David Miller
From: Eric Dumazet Date: Mon, 13 Jun 2016 11:33:32 -0700 > From: Eric Dumazet > > Now prio_init() can return -ENOMEM, it also has to make sure > any allocated qdiscs are freed, since the caller (qdisc_create()) wont > call ->destroy() handler for us. > > More generally, we want a transactional

Re: [PATCH v2 net] net_sched: prio: insure proper transactional behavior

2016-06-13 Thread Cong Wang
On Mon, Jun 13, 2016 at 11:33 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Now prio_init() can return -ENOMEM, it also has to make sure > any allocated qdiscs are freed, since the caller (qdisc_create()) wont > call ->destroy() handler for us. > > More generally, we want a transactional behav

[PATCH v2 net] net_sched: prio: insure proper transactional behavior

2016-06-13 Thread Eric Dumazet
From: Eric Dumazet Now prio_init() can return -ENOMEM, it also has to make sure any allocated qdiscs are freed, since the caller (qdisc_create()) wont call ->destroy() handler for us. More generally, we want a transactional behavior for "tc qdisc change ...", so prio_tune() should not make modif