Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Vladimir Oltean writes: [...] >> Acked-by: Vladimir Oltean >> >> Thanks, >> -Vladimir > > Of course, it would be good if you sent a new version with the sha1sum > of the Fixes: tag having the right length, otherwise people will > complain. Ah, thanks for reminding! I entirely forgot about it

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

On Tue, Jul 14, 2020 at 05:23:24PM +0300, Vladimir Oltean wrote: > On Tue, Jul 14, 2020 at 03:39:04PM +0300, Sergey Organov wrote: > > Vladimir Oltean writes: > > > > > On Mon, Jul 13, 2020 at 01:32:09AM +0300, Sergey Organov wrote: > > > > [...] > > > > >> > From the perspective of the mainlin

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Vladimir Oltean writes: > On Tue, Jul 14, 2020 at 03:39:04PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > On Mon, Jul 13, 2020 at 01:32:09AM +0300, Sergey Organov wrote: >> >> [...] >> >> >> > From the perspective of the mainline kernel, that can never happen. >> >> >> >> Y

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Richard Cochran writes: > On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: >> Fix support for external PTP-aware devices such as DSA or PTP PHY: >> >> Make sure we never time stamp tx packets when hardware time stamping >> is disabled. >> >> Check for PTP PHY being in use and the

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

On Tue, Jul 14, 2020 at 03:39:04PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > On Mon, Jul 13, 2020 at 01:32:09AM +0300, Sergey Organov wrote: > > [...] > > >> > From the perspective of the mainline kernel, that can never happen. > >> > >> Yet in happened to me, and in some way

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: > Fix support for external PTP-aware devices such as DSA or PTP PHY: > > Make sure we never time stamp tx packets when hardware time stamping > is disabled. > > Check for PTP PHY being in use and then pass ioctls related to time > st

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Vladimir Oltean writes: > On Mon, Jul 13, 2020 at 01:32:09AM +0300, Sergey Organov wrote: [...] >> > From the perspective of the mainline kernel, that can never happen. >> >> Yet in happened to me, and in some way because of the UAPI deficiencies >> I've mentioned, as ethtool has entirely separ

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

On Mon, Jul 13, 2020 at 01:32:09AM +0300, Sergey Organov wrote: > > > > If you run "ethtool -T eth0" on a FEC network interface, it will always > > report its own PHC, and never the PHC of a PHY. So, you cannot claim > > that you are fixing PHY timestamping, since PHY timestamping is not > > advert

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Vladimir Oltean writes: > On Sun, Jul 12, 2020 at 08:29:46PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > As far as I understand. the reason why SKBTX_IN_PROGRESS exists is for >> > skb_tx_timestamp() to only provide a software timestamp if the hardware >> > timestamping isn'

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

On Sun, Jul 12, 2020 at 08:29:46PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > As far as I understand. the reason why SKBTX_IN_PROGRESS exists is for > > skb_tx_timestamp() to only provide a software timestamp if the hardware > > timestamping isn't going to. So hardware timestamp

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Vladimir Oltean writes: > On Sun, Jul 12, 2020 at 05:16:56PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > Hi Sergey, >> > >> > On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: >> >> Fix support for external PTP-aware devices such as DSA or PTP PHY: >> >> >> >>

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

On Sun, Jul 12, 2020 at 05:16:56PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > Hi Sergey, > > > > On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: > >> Fix support for external PTP-aware devices such as DSA or PTP PHY: > >> > >> Make sure we never time stamp tx pa

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

> I did as you suggested: > > [pretty] > fixes = Fixes: %h (\"%s\") > [alias] > fixes = show --no-patch --pretty='Fixes: %h (\"%s\")' > > And that's what it gave me. Dunno, maybe its Git version that is > responsible? [core] abbrev = 12 Andrew

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Vladimir Oltean writes: > Hi Sergey, > > On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: >> Fix support for external PTP-aware devices such as DSA or PTP PHY: >> >> Make sure we never time stamp tx packets when hardware time stamping >> is disabled. >> >> Check for PTP PHY being

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

Hi Sergey, On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: > Fix support for external PTP-aware devices such as DSA or PTP PHY: > > Make sure we never time stamp tx packets when hardware time stamping > is disabled. > > Check for PTP PHY being in use and then pass ioctls related

[PATCH v2 net] net: fec: fix hardware time stamping by external devices

Fix support for external PTP-aware devices such as DSA or PTP PHY: Make sure we never time stamp tx packets when hardware time stamping is disabled. Check for PTP PHY being in use and then pass ioctls related to time stamping of Ethernet packets to the PTP PHY rather than handle them ourselves. I