Re: [PATCH v2 net] net: Properly update v4 routes with v6 nexthop

2019-09-03 Thread David Ahern
On 8/31/19 6:22 AM, Donald Sharp wrote: > @@ -1684,7 +1684,8 @@ EXPORT_SYMBOL_GPL(fib_add_nexthop); > #endif > > #ifdef CONFIG_IP_ROUTE_MULTIPATH > -static int fib_add_multipath(struct sk_buff *skb, struct fib_info *fi) > +static int fib_add_multipath(struct sk_buff *skb, struct fib_info *fi, >

Re: [PATCH v2 net] net: Properly update v4 routes with v6 nexthop

2019-08-31 Thread David Ahern
On 8/31/19 6:22 AM, Donald Sharp wrote: > When creating a v4 route that uses a v6 nexthop from a nexthop group. > Allow the kernel to properly send the nexthop as v6 via the RTA_VIA > attribute. > Dave: I am on PTO with little time through Monday. I will review/test on Tuesday.

[PATCH v2 net] net: Properly update v4 routes with v6 nexthop

2019-08-31 Thread Donald Sharp
When creating a v4 route that uses a v6 nexthop from a nexthop group. Allow the kernel to properly send the nexthop as v6 via the RTA_VIA attribute. Broken behavior: $ ip nexthop add via fe80::9 dev eth0 $ ip nexthop show id 1 via fe80::9 dev eth0 scope link $ ip route add 4.5.6.7/32 nhid 1 $ ip