On 16-06-06 12:18 PM, Florian Westphal wrote:
Eric Dumazet wrote:
On Mon, 2016-06-06 at 13:42 +0200, Florian Westphal wrote:
Jamal Hadi Salim wrote:
BTW, returning NET_XMIT_CN could be confusing to tcp;
it does not mean that the packet that we are getting return
code for was dropped; it coul
From: Eric Dumazet
Date: Sat, 04 Jun 2016 12:55:13 -0700
> From: Eric Dumazet
>
> My prior attempt to fix the backlogs of parents failed.
>
> If we return NET_XMIT_CN, our parents wont increase their backlog,
> so our qdisc_tree_reduce_backlog() should take this into account.
>
> v2: Florian
Eric Dumazet wrote:
> On Mon, 2016-06-06 at 13:42 +0200, Florian Westphal wrote:
> > Jamal Hadi Salim wrote:
> > > BTW, returning NET_XMIT_CN could be confusing to tcp;
> > > it does not mean that the packet that we are getting return
> > > code for was dropped; it could mean _another_ packet in
On Mon, 2016-06-06 at 13:42 +0200, Florian Westphal wrote:
> Jamal Hadi Salim wrote:
> > BTW, returning NET_XMIT_CN could be confusing to tcp;
> > it does not mean that the packet that we are getting return
> > code for was dropped; it could mean _another_ packet in
> > the queue was dropped.
>
>
On Mon, 2016-06-06 at 06:49 -0400, Jamal Hadi Salim wrote:
> On 16-06-05 07:30 PM, Cong Wang wrote:
>
> > Potentially all of the following:
> >
> > net/sched/sch_choke.c: return NET_XMIT_CN;
> > net/sched/sch_fifo.c: return NET_XMIT_CN;
> > net/sched/sch_generic.c:return NET_XMIT_CN;
>
Jamal Hadi Salim wrote:
> BTW, returning NET_XMIT_CN could be confusing to tcp;
> it does not mean that the packet that we are getting return
> code for was dropped; it could mean _another_ packet in
> the queue was dropped.
Yes, but we currently conceal NET_XMIT_CN from upper layer (tcp)
via the
On 16-06-05 07:30 PM, Cong Wang wrote:
Potentially all of the following:
net/sched/sch_choke.c: return NET_XMIT_CN;
net/sched/sch_fifo.c: return NET_XMIT_CN;
net/sched/sch_generic.c:return NET_XMIT_CN;
net/sched/sch_gred.c: return NET_XMIT_CN;
net/sched/sch_hhf.c:return
On Sun, Jun 5, 2016 at 1:55 PM, Eric Dumazet wrote:
> On Sun, 2016-06-05 at 13:54 -0700, Eric Dumazet wrote:
>
>> BTW, we might need a similar fix in sch_fq.c
>
> I meant sch_sfq.c
>
Potentially all of the following:
net/sched/sch_choke.c: return NET_XMIT_CN;
net/sched/sch_fifo.c: return NET_
On Sun, 2016-06-05 at 13:54 -0700, Eric Dumazet wrote:
> BTW, we might need a similar fix in sch_fq.c
I meant sch_sfq.c
On Sun, 2016-06-05 at 13:30 -0700, Cong Wang wrote:
> On Sat, Jun 4, 2016 at 12:55 PM, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > My prior attempt to fix the backlogs of parents failed.
> >
> > If we return NET_XMIT_CN, our parents wont increase their backlog,
> > so our qdisc_tree_reduce
On Sat, Jun 4, 2016 at 12:55 PM, Eric Dumazet wrote:
> From: Eric Dumazet
>
> My prior attempt to fix the backlogs of parents failed.
>
> If we return NET_XMIT_CN, our parents wont increase their backlog,
> so our qdisc_tree_reduce_backlog() should take this into account.
>
Acked-by: Cong Wang
On 16-06-04 03:55 PM, Eric Dumazet wrote:
From: Eric Dumazet
My prior attempt to fix the backlogs of parents failed.
If we return NET_XMIT_CN, our parents wont increase their backlog,
so our qdisc_tree_reduce_backlog() should take this into account.
v2: Florian Westphal pointed out that we co
From: Eric Dumazet
My prior attempt to fix the backlogs of parents failed.
If we return NET_XMIT_CN, our parents wont increase their backlog,
so our qdisc_tree_reduce_backlog() should take this into account.
v2: Florian Westphal pointed out that we could drop the packet,
so we need to save qdis
13 matches
Mail list logo
